You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2014/10/28 00:27:43 UTC
[GitHub] cordova-js pull request: CB-7868 Use utils.defineGetterSetter inst...
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-js/pull/88
CB-7868 Use utils.defineGetterSetter instead of Object.defineProperty
Object.defineProperty is not available on some android versions. Our own util function checks this, so we should just call it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-js CB-7868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit bd5a35fac8ce04deda9317831aea3a4489b9fc33
Author: purplecabbage <pu...@gmail.com>
Date: 2014-10-27T22:56:01Z
CB-7868 Use utils.defineGetterSetter instead of Object.defineProperty which may or may not be defined
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-7868 Use utils.defineGetterSetter inst...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org