You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by karup1990 <gi...@git.apache.org> on 2016/11/08 18:07:22 UTC
[GitHub] zeppelin pull request #1613: ZEPPELIN-1643:Make spark web UI accesible from ...
GitHub user karup1990 opened a pull request:
https://github.com/apache/zeppelin/pull/1613
ZEPPELIN-1643:Make spark web UI accesible from interpreters page
### What is this PR for?
Make spark web UI accesible from interpreters page
### What type of PR is it?
Improvement
### Todos
NA
### What is the Jira issue?
ZEPPELIN-1643
### How should this be tested?
Start sparkcontext.
Goto interpreters page. Corresponding to the spark interpreter used in notebook, there will be *spark ui* button.
Clicking the button should open a new tab with the application's spark web UI.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NA
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1643
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1613.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1613
----
commit 3b47fe6dd2dc5125efd86e58a91bc66772d6c011
Author: karuppayya <ka...@gmail.com>
Date: 2016-11-08T17:50:09Z
Change to make spark web UI accesible from interpreters page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1613
@zjffdu Right. Isolated mode can create multiple spark applications.
@karup1990 @zjffdu how can we handle multiple spark applications?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1613: ZEPPELIN-1643:Make spark web UI accesible from ...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 closed the pull request at:
https://github.com/apache/zeppelin/pull/1613
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1613
I think the right place to put spark ui link is in note page instead of interpreter setting page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
I did a code reading to see how to fix this.. Looks like I will need to handle it per user as well.
To complete this PR, I can quickly make the changes to show the link in interpreter page, only for per note scoped and global mode.
Else , I will try to fix all modes(user, note, global) and then create a PR.
@zjffdu @Leemoonsoo let me know your thoughts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1613
If I read it correctly, this PR assume each interpreter setting has one spark ui url ? But I think this is wrong assumption, as we may have multiple spark applications for single interpreter setting. @karup1990 @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
Failure seems unrelated.
`03:55:19,906 ERROR org.apache.zeppelin.AbstractZeppelinIT:136 - Exception in ParagraphActionsIT while testEditOnDoubleClick `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
@zjffdu @Leemoonsoo Thanks for letting me know.
I will make the changes to handle isolated scope as well and create a PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1613: ZEPPELIN-1643:Make spark web UI accesible from ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1613
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
@Leemoonsoo Thanks for the suggestions.
I have refactored the code now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1613: ZEPPELIN-1643:Make spark web UI accesible from ...
Posted by karup1990 <gi...@git.apache.org>.
GitHub user karup1990 reopened a pull request:
https://github.com/apache/zeppelin/pull/1613
ZEPPELIN-1643:Make spark web UI accesible from interpreters page
### What is this PR for?
Make spark web UI accesible from interpreters page
### What type of PR is it?
Improvement
### Todos
NA
### What is the Jira issue?
ZEPPELIN-1643
### How should this be tested?
Start sparkcontext.
Goto interpreters page. Corresponding to the spark interpreter used in notebook, there will be *spark ui* button.
Clicking the button should open a new tab with the application's spark web UI.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NA
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1643
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1613.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1613
----
commit 3b47fe6dd2dc5125efd86e58a91bc66772d6c011
Author: karuppayya <ka...@gmail.com>
Date: 2016-11-08T17:50:09Z
Change to make spark web UI accesible from interpreters page
commit a0ff3dbfdebc7a303d25058c6eee50e360c53c87
Author: karuppayya <ka...@gmail.com>
Date: 2016-11-08T18:08:16Z
Remove comments
commit 2d065c818133539d6a3634c82183dcd1b7042622
Author: karuppayya <ka...@gmail.com>
Date: 2016-11-09T16:28:58Z
Address feedback
commit 8f08385862ad6e45c37122ca4f25499e6e8635a5
Author: karuppayya <ka...@gmail.com>
Date: 2016-11-09T17:23:09Z
Fix test failure
commit 538225ce11d5c1dd5139182a8640b6f36937352f
Author: Karup <ka...@outlook.com>
Date: 2016-11-12T17:25:54Z
Fix typo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1613
Make sense. @karup1990 what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1613
LGTM. Merge if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
@zjffdu @Leemoonsoo I have handled the cases in https://github.com/apache/zeppelin/pull/1678
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---