You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/07/25 22:52:41 UTC

[commons-io] 01/03: Use try-with-resources which also allows us to test close()

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git

commit 42bbcd0d34bd9efab0d85169441486762a54187f
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Jul 25 18:48:48 2022 -0400

    Use try-with-resources which also allows us to test close()
---
 .../apache/commons/io/DemuxInputStreamTest.java    | 60 +++++++++++-----------
 1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/src/test/java/org/apache/commons/io/DemuxInputStreamTest.java b/src/test/java/org/apache/commons/io/DemuxInputStreamTest.java
index ae3aa1e2..668f93cf 100644
--- a/src/test/java/org/apache/commons/io/DemuxInputStreamTest.java
+++ b/src/test/java/org/apache/commons/io/DemuxInputStreamTest.java
@@ -161,39 +161,39 @@ public class DemuxInputStreamTest {
     }
 
     @Test
-    public void testInputStream()
-            throws Exception {
-        final DemuxInputStream input = new DemuxInputStream();
-        startReader(T1, DATA1, input);
-        startReader(T2, DATA2, input);
-        startReader(T3, DATA3, input);
-        startReader(T4, DATA4, input);
-
-        doStart();
-        doJoin();
-
-        assertEquals(DATA1, getInput(T1), "Data1");
-        assertEquals(DATA2, getInput(T2), "Data2");
-        assertEquals(DATA3, getInput(T3), "Data3");
-        assertEquals(DATA4, getInput(T4), "Data4");
+    public void testInputStream() throws Exception {
+        try (final DemuxInputStream input = new DemuxInputStream()) {
+            startReader(T1, DATA1, input);
+            startReader(T2, DATA2, input);
+            startReader(T3, DATA3, input);
+            startReader(T4, DATA4, input);
+
+            doStart();
+            doJoin();
+
+            assertEquals(DATA1, getInput(T1), "Data1");
+            assertEquals(DATA2, getInput(T2), "Data2");
+            assertEquals(DATA3, getInput(T3), "Data3");
+            assertEquals(DATA4, getInput(T4), "Data4");
+        }
     }
 
     @Test
-    public void testOutputStream()
-            throws Exception {
-        final DemuxOutputStream output = new DemuxOutputStream();
-        startWriter(T1, DATA1, output);
-        startWriter(T2, DATA2, output);
-        startWriter(T3, DATA3, output);
-        startWriter(T4, DATA4, output);
-
-        doStart();
-        doJoin();
-
-        assertEquals(DATA1, getOutput(T1), "Data1");
-        assertEquals(DATA2, getOutput(T2), "Data2");
-        assertEquals(DATA3, getOutput(T3), "Data3");
-        assertEquals(DATA4, getOutput(T4), "Data4");
+    public void testOutputStream() throws Exception {
+        try (final DemuxOutputStream output = new DemuxOutputStream()) {
+            startWriter(T1, DATA1, output);
+            startWriter(T2, DATA2, output);
+            startWriter(T3, DATA3, output);
+            startWriter(T4, DATA4, output);
+
+            doStart();
+            doJoin();
+
+            assertEquals(DATA1, getOutput(T1), "Data1");
+            assertEquals(DATA2, getOutput(T2), "Data2");
+            assertEquals(DATA3, getOutput(T3), "Data3");
+            assertEquals(DATA4, getOutput(T4), "Data4");
+        }
     }
 }