You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/31 11:43:00 UTC

[GitHub] [arrow] Dandandan opened a new pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Dandandan opened a new pull request #9380:
URL: https://github.com/apache/arrow/pull/9380


   Changes the functions to accept `&[T]` instead of `&Vec<ScalarValue>`. Besides being more idiomatic, in some cases this will allow not creating a `Vec` at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

Dandandan commented on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-772789873


   Thanks @alamb rebased


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

alamb commented on a change in pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#discussion_r568797759



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -734,16 +734,10 @@ fn aggregate_batch(
 
             // 1.3
             match mode {
-                AggregateMode::Partial => {
-                    accum.update_batch(values)?;
-                }
-                AggregateMode::Final => {
-                    accum.merge_batch(values)?;
-                }
+                AggregateMode::Partial => accum.update_batch(values),
+                AggregateMode::Final => accum.merge_batch(values),
             }
-            Ok(accum)
         })
-        .collect::<Result<Vec<_>>>()

Review comment:
       makes sense to me. 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

Dandandan commented on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-771834794


   Yes, this should be backwards compatible indeed @alamb  👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

Dandandan commented on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-771834794


   Yes, this should be backwards compatible indeed @alamb  👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

alamb commented on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-772781707


   I merged this PR into master and re-ran the tests locally. Everything is looking fine. 👍  merging it in
   
   FYI @jorgecarleitao and @andygrove 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb edited a comment on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

alamb edited a comment on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-772781707


   ~I merged this PR into master and re-ran the tests locally. Everything is looking fine. 👍  merging it in~
   
   FYI @jorgecarleitao and @andygrove 
   
   Update: clippy now fails locally (probably due to code introduced as part of https://github.com/apache/arrow/pull/9364) -- can you please rebase this @Dandandan ?
   
   ```
   error: useless use of `vec!`
      --> datafusion/src/sql/planner.rs:481:25
       |
   481 |                         &vec![having_expr.clone()],
       |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[having_expr.clone()]`
       |
       = note: `-D clippy::useless-vec` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   
   error: useless use of `vec!`
      --> datafusion/src/sql/planner.rs:602:17
       |
   602 |                 &vec![having_expr_post_aggr.clone()],
       |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[having_expr_post_aggr.clone()]`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

alamb commented on a change in pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#discussion_r568797759



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -734,16 +734,10 @@ fn aggregate_batch(
 
             // 1.3
             match mode {
-                AggregateMode::Partial => {
-                    accum.update_batch(values)?;
-                }
-                AggregateMode::Final => {
-                    accum.merge_batch(values)?;
-                }
+                AggregateMode::Partial => accum.update_batch(values),
+                AggregateMode::Final => accum.merge_batch(values),
             }
-            Ok(accum)
         })
-        .collect::<Result<Vec<_>>>()

Review comment:
       makes sense to me. 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-770371351


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=h1) Report
   > Merging [#9380](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=desc) (c22d005) into [master](https://codecov.io/gh/apache/arrow/commit/484ff4d19470c01a5de82b1bc1735d9786757826?el=desc) (484ff4d) will **increase** coverage by `0.00%`.
   > The diff coverage is `77.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9380/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9380   +/-   ##
   =======================================
     Coverage   81.96%   81.97%           
   =======================================
     Files         230      230           
     Lines       53361    53373   +12     
   =======================================
   + Hits        43738    43751   +13     
   + Misses       9623     9622    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/datafusion/examples/simple\_udaf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL3NpbXBsZV91ZGFmLnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `80.00% <ø> (ø)` | |
   | [rust/datafusion/src/logical\_plan/expr.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXhwci5ycw==) | `79.95% <ø> (ø)` | |
   | [rust/datafusion/src/logical\_plan/extension.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXh0ZW5zaW9uLnJz) | `0.00% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BhcnF1ZXQucnM=) | `88.24% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/planner.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BsYW5uZXIucnM=) | `79.16% <ø> (+0.37%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/projection.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3Byb2plY3Rpb24ucnM=) | `84.93% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udaf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkYWYucnM=) | `78.94% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkZi5ycw==) | `78.26% <ø> (ø)` | |
   | [rust/datafusion/src/test/user\_defined.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy90ZXN0L3VzZXJfZGVmaW5lZC5ycw==) | `78.94% <ø> (ø)` | |
   | ... and [24 more](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=footer). Last update [484ff4d...c22d005](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

alamb closed pull request #9380:
URL: https://github.com/apache/arrow/pull/9380


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-770371351


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=h1) Report
   > Merging [#9380](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=desc) (b0e8e22) into [master](https://codecov.io/gh/apache/arrow/commit/3d4c2bb29bb89dfc7e24bd1295f81849664e46ef?el=desc) (3d4c2bb) will **increase** coverage by `0.00%`.
   > The diff coverage is `78.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9380/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9380   +/-   ##
   =======================================
     Coverage   82.10%   82.11%           
   =======================================
     Files         230      230           
     Lines       54043    54040    -3     
   =======================================
   + Hits        44374    44375    +1     
   + Misses       9669     9665    -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/datafusion/examples/simple\_udaf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL3NpbXBsZV91ZGFmLnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `80.00% <ø> (ø)` | |
   | [rust/datafusion/src/logical\_plan/expr.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXhwci5ycw==) | `80.23% <ø> (ø)` | |
   | [rust/datafusion/src/logical\_plan/extension.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXh0ZW5zaW9uLnJz) | `0.00% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BhcnF1ZXQucnM=) | `88.10% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/planner.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BsYW5uZXIucnM=) | `79.16% <ø> (+0.37%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/projection.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3Byb2plY3Rpb24ucnM=) | `84.93% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udaf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkYWYucnM=) | `78.94% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkZi5ycw==) | `78.26% <ø> (ø)` | |
   | [rust/datafusion/src/test/user\_defined.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy90ZXN0L3VzZXJfZGVmaW5lZC5ycw==) | `78.94% <ø> (ø)` | |
   | ... and [20 more](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=footer). Last update [3d4c2bb...b0e8e22](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on a change in pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

Dandandan commented on a change in pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#discussion_r567429222



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -734,16 +734,10 @@ fn aggregate_batch(
 
             // 1.3
             match mode {
-                AggregateMode::Partial => {
-                    accum.update_batch(values)?;
-                }
-                AggregateMode::Final => {
-                    accum.merge_batch(values)?;
-                }
+                AggregateMode::Partial => accum.update_batch(values),
+                AggregateMode::Final => accum.merge_batch(values),
             }
-            Ok(accum)
         })
-        .collect::<Result<Vec<_>>>()

Review comment:
       Small cleanup here, to not collect it needlessly into a vec (as it is the same as the input anyway, and it mutates the accumulators, so it's more clear and slightly more efficient now).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-770371351


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=h1) Report
   > Merging [#9380](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=desc) (760e0fd) into [master](https://codecov.io/gh/apache/arrow/commit/484ff4d19470c01a5de82b1bc1735d9786757826?el=desc) (484ff4d) will **increase** coverage by `0.00%`.
   > The diff coverage is `77.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9380/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9380   +/-   ##
   =======================================
     Coverage   81.96%   81.96%           
   =======================================
     Files         230      230           
     Lines       53361    53360    -1     
   =======================================
     Hits        43738    43738           
   + Misses       9623     9622    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/datafusion/examples/simple\_udaf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL3NpbXBsZV91ZGFmLnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `80.00% <ø> (ø)` | |
   | [rust/datafusion/src/logical\_plan/expr.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXhwci5ycw==) | `79.95% <ø> (ø)` | |
   | [rust/datafusion/src/logical\_plan/extension.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZXh0ZW5zaW9uLnJz) | `0.00% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BhcnF1ZXQucnM=) | `88.24% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/planner.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BsYW5uZXIucnM=) | `79.16% <ø> (+0.37%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/projection.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3Byb2plY3Rpb24ucnM=) | `84.93% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udaf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkYWYucnM=) | `78.94% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udf.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkZi5ycw==) | `78.26% <ø> (ø)` | |
   | [rust/datafusion/src/test/user\_defined.rs](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy90ZXN0L3VzZXJfZGVmaW5lZC5ycw==) | `78.94% <ø> (ø)` | |
   | ... and [21 more](https://codecov.io/gh/apache/arrow/pull/9380/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=footer). Last update [484ff4d...760e0fd](https://codecov.io/gh/apache/arrow/pull/9380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-770369073


   https://issues.apache.org/jira/browse/ARROW-11444


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org