You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/11/17 00:24:42 UTC
Review Request: Fix for doing executor setup inside the forked process in
cgroups isolation module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup
This addresses bug MESOS-310.
https://issues.apache.org/jira/browse/MESOS-310
Diffs
-----
src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
Diff: https://reviews.apache.org/r/8096/diff/
Testing
-------
sudo make check
Thanks,
Vinod Kone
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 18, 2012, 12:33 a.m., Ben Mahler wrote:
> > Great, this is all that's needed to fix MESOS-310 right?
> >
> > Also, I recall some discussion about this bit of code already, in terms of where to place it, do you remember what the context was?
We wanted to split the launcher because it was being called both from the slave process and its forked process. I think we are fine now because all of the launcher code is being called inside the forked process.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/#review13541
-----------------------------------------------------------
On Nov. 16, 2012, 11:24 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8096/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2012, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
>
> This accomplishes two things:
> --> unblocks the cgroups isolation module from any potential hangs during executor setup
> --> does not charge (for memory) the executor for the setup
>
>
> This addresses bug MESOS-310.
> https://issues.apache.org/jira/browse/MESOS-310
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
> src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
>
> Diff: https://reviews.apache.org/r/8096/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/#review13541
-----------------------------------------------------------
Ship it!
Great, this is all that's needed to fix MESOS-310 right?
Also, I recall some discussion about this bit of code already, in terms of where to place it, do you remember what the context was?
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/8096/#comment29096>
Link to the pertinent cgroup doc would be good for posterity.
- Ben Mahler
On Nov. 16, 2012, 11:24 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8096/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2012, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
>
> This accomplishes two things:
> --> unblocks the cgroups isolation module from any potential hangs during executor setup
> --> does not charge (for memory) the executor for the setup
>
>
> This addresses bug MESOS-310.
> https://issues.apache.org/jira/browse/MESOS-310
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
> src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
>
> Diff: https://reviews.apache.org/r/8096/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/#review14313
-----------------------------------------------------------
Ship it!
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/8096/#comment30473>
Thanks!
- Benjamin Hindman
On Nov. 19, 2012, 3:49 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8096/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 3:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
>
> This accomplishes two things:
> --> unblocks the cgroups isolation module from any potential hangs during executor setup
> --> does not charge (for memory) the executor for the setup
>
>
> This addresses bug MESOS-310.
> https://issues.apache.org/jira/browse/MESOS-310
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
> src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
>
> Diff: https://reviews.apache.org/r/8096/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/
-----------------------------------------------------------
(Updated Feb. 9, 2013, 12:05 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
No need to re-review. Just uploading a rebased diff for posterity.
Submitting now.
Description
-------
Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup
This addresses bugs MESOS-262 and MESOS-310.
https://issues.apache.org/jira/browse/MESOS-262
https://issues.apache.org/jira/browse/MESOS-310
Diffs (updated)
-----
src/slave/cgroups_isolation_module.cpp 63cefc3
src/slave/process_based_isolation_module.cpp 3d50a4b
Diff: https://reviews.apache.org/r/8096/diff/
Testing
-------
sudo make check
Thanks,
Vinod Kone
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/
-----------------------------------------------------------
(Updated Feb. 7, 2013, 11:12 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Added bug MESOS-262.
Description
-------
Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup
This addresses bugs MESOS-262 and MESOS-310.
https://issues.apache.org/jira/browse/MESOS-262
https://issues.apache.org/jira/browse/MESOS-310
Diffs
-----
src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
Diff: https://reviews.apache.org/r/8096/diff/
Testing
-------
sudo make check
Thanks,
Vinod Kone
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/
-----------------------------------------------------------
(Updated Nov. 19, 2012, 3:49 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
linked cgroup memory doc.
Description
-------
Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup
This addresses bug MESOS-310.
https://issues.apache.org/jira/browse/MESOS-310
Diffs (updated)
-----
src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
Diff: https://reviews.apache.org/r/8096/diff/
Testing
-------
sudo make check
Thanks,
Vinod Kone