You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by ab...@apache.org on 2019/10/20 14:39:36 UTC

[ranger] branch master updated: RANGER-2626: Block unauthenticated access to Ranger REST endpoints in kerberized environment

This is an automated email from the ASF dual-hosted git repository.

abhay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new 522d1cc  RANGER-2626: Block unauthenticated access to Ranger REST endpoints in kerberized environment
522d1cc is described below

commit 522d1ccd2a05921d7563b921e617c50fee30c40d
Author: Abhay Kulkarni <ab...@apache.org>
AuthorDate: Sun Oct 20 07:39:26 2019 -0700

    RANGER-2626: Block unauthenticated access to Ranger REST endpoints in kerberized environment
---
 .../src/main/java/org/apache/ranger/biz/RangerBizUtil.java | 14 ++++++++++++++
 .../src/main/java/org/apache/ranger/rest/RoleREST.java     |  1 +
 .../src/main/java/org/apache/ranger/rest/ServiceREST.java  |  6 ++++++
 .../src/main/java/org/apache/ranger/rest/TagREST.java      |  2 ++
 4 files changed, 23 insertions(+)

diff --git a/security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java b/security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
index 58cf790..abb1b10 100644
--- a/security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
+++ b/security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
@@ -35,7 +35,9 @@ import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.io.FilenameUtils;
 import org.apache.commons.io.IOCase;
 import org.apache.commons.lang.StringUtils;
+import org.apache.hadoop.security.UserGroupInformation;
 import org.apache.log4j.Logger;
+import org.apache.ranger.authorization.hadoop.config.RangerConfiguration;
 import org.apache.ranger.common.AppConstants;
 import org.apache.ranger.common.ContextUtil;
 import org.apache.ranger.common.GUIDUtil;
@@ -439,6 +441,18 @@ public class RangerBizUtil {
 		return matchFound;
 	}
 
+	public static void failUnauthenticatedIfNotAllowed() throws Exception {
+		if (UserGroupInformation.isSecurityEnabled()) {
+			UserSessionBase currentUserSession = ContextUtil.getCurrentUserSession();
+			if (currentUserSession == null) {
+				boolean allowUnauthenticatedAccessInSecureEnvironment = RangerConfiguration.getInstance().getBoolean("ranger.admin.allow.unauthenticated.access", false);
+				if (!allowUnauthenticatedAccessInSecureEnvironment) {
+					throw new Exception("Unauthenticated access not allowed");
+				}
+			}
+		}
+	}
+
 	/**
 	 * returns true if user is having required permission on given Hbase
 	 * resource
diff --git a/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java b/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java
index fa3a318..fdda883 100644
--- a/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java
+++ b/security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java
@@ -716,6 +716,7 @@ public class RoleREST {
         String  logMsg            = null;
 
         try {
+            bizUtil.failUnauthenticatedIfNotAllowed();
             isValid = serviceUtil.isValidService(serviceName, request);
         } catch (WebApplicationException webException) {
             httpCode = webException.getResponse().getStatus();
diff --git a/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java b/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
index 852c2c8..d60b738 100644
--- a/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
+++ b/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
@@ -1199,6 +1199,8 @@ public class ServiceREST {
 			if (serviceUtil.isValidateHttpsAuthentication(serviceName, request)) {
 
 				try {
+					bizUtil.failUnauthenticatedIfNotAllowed();
+
 					if(RangerPerfTracer.isPerfTraceEnabled(PERF_LOG)) {
 						perf = RangerPerfTracer.getPerfTracer(PERF_LOG, "ServiceREST.grantAccess(serviceName=" + serviceName + ")");
 					}
@@ -1427,6 +1429,8 @@ public class ServiceREST {
 			if (serviceUtil.isValidateHttpsAuthentication(serviceName,request)) {
 
 				try {
+					bizUtil.failUnauthenticatedIfNotAllowed();
+
 					if(RangerPerfTracer.isPerfTraceEnabled(PERF_LOG)) {
 						perf = RangerPerfTracer.getPerfTracer(PERF_LOG, "ServiceREST.revokeAccess(serviceName=" + serviceName + ")");
 					}
@@ -2999,6 +3003,8 @@ public class ServiceREST {
 		boolean isValid          = false;
 
 		try {
+			bizUtil.failUnauthenticatedIfNotAllowed();
+
 			isValid = serviceUtil.isValidateHttpsAuthentication(serviceName, request);
 		} catch (WebApplicationException webException) {
 			httpCode = webException.getResponse().getStatus();
diff --git a/security-admin/src/main/java/org/apache/ranger/rest/TagREST.java b/security-admin/src/main/java/org/apache/ranger/rest/TagREST.java
index 8b58208..dfaccdd 100644
--- a/security-admin/src/main/java/org/apache/ranger/rest/TagREST.java
+++ b/security-admin/src/main/java/org/apache/ranger/rest/TagREST.java
@@ -1124,6 +1124,8 @@ public class TagREST {
 		}
 
         try {
+            bizUtil.failUnauthenticatedIfNotAllowed();
+
             ret = tagStore.getServiceTagsIfUpdated(serviceName, lastKnownVersion, !supportsTagDeltas);
 
             if (ret == null) {