You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "koarz (via GitHub)" <gi...@apache.org> on 2024/02/08 06:52:02 UTC
[PR] [enhancement](function) change some function nullable mode [doris]
koarz opened a new pull request, #30991:
URL: https://github.com/apache/doris/pull/30991
## Proposed changes
Issue Number: close #27435
<!--Describe your changes.-->
change some function nullable mode, and change function unhex ,to_base64, from_base64,will return empty string when input empty string
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934391117
TeamCity be ut coverage result:
Function Coverage: 35.84% (8559/23881)
Line Coverage: 27.78% (69478/250140)
Region Coverage: 26.91% (36044/133942)
Branch Coverage: 23.69% (18426/77784)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60e81e94379af7d292ae65da66593242adf9e7f4_60e81e94379af7d292ae65da66593242adf9e7f4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935559809
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934561606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934279989
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934227043
<details>
<summary>TPC-DS: <b>Total hot run time: 179995 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2fb8693e3748879ca5d37f98b7146d69ccce050a, data reload: false
query1 921 348 348 348
query2 6561 1720 1714 1714
query3 6696 211 200 200
query4 24494 22428 22475 22428
query5 4263 468 377 377
query6 261 168 166 166
query7 4609 293 285 285
query8 251 191 188 188
query9 8425 2787 2787 2787
query10 418 230 229 229
query11 16152 15704 15373 15373
query12 132 82 86 82
query13 1691 419 412 412
query14 8943 7506 7565 7506
query15 214 190 190 190
query16 7319 250 252 250
query17 1402 569 526 526
query18 1971 266 255 255
query19 190 145 148 145
query20 86 82 84 82
query21 189 121 116 116
query22 5030 4830 4807 4807
query23 32500 31600 31677 31600
query24 12646 3375 3369 3369
query25 649 378 363 363
query26 1865 158 151 151
query27 3064 307 317 307
query28 6571 1832 1812 1812
query29 1159 611 607 607
query30 282 137 142 137
query31 945 762 786 762
query32 99 57 54 54
query33 726 238 224 224
query34 1076 489 487 487
query35 946 805 806 805
query36 1007 896 917 896
query37 169 57 63 57
query38 3405 3278 3299 3278
query39 1369 1343 1303 1303
query40 284 104 104 104
query41 36 34 34 34
query42 105 100 97 97
query43 488 452 458 452
query44 1067 682 694 682
query45 199 181 183 181
query46 1048 768 729 729
query47 1704 1646 1572 1572
query48 402 347 349 347
query49 1251 306 299 299
query50 768 378 379 378
query51 5290 5213 5153 5153
query52 107 94 85 85
query53 394 296 300 296
query54 299 215 216 215
query55 86 74 80 74
query56 225 198 193 193
query57 1038 969 961 961
query58 219 193 202 193
query59 2308 2248 2292 2248
query60 243 219 217 217
query61 83 87 81 81
query62 605 358 374 358
query63 329 281 274 274
query64 6411 3087 3167 3087
query65 3292 3270 3234 3234
query66 1355 324 318 318
query67 14713 14475 14205 14205
query68 5046 534 552 534
query69 515 347 342 342
query70 1279 1184 1217 1184
query71 427 252 270 252
query72 6267 2794 2614 2614
query73 691 308 315 308
query74 7069 6702 6622 6622
query75 3203 2538 2535 2535
query76 3293 1143 1202 1143
query77 354 242 225 225
query78 9520 8764 8722 8722
query79 960 510 493 493
query80 512 340 341 340
query81 436 204 202 202
query82 162 82 83 82
query83 137 118 121 118
query84 226 75 78 75
query85 1036 345 345 345
query86 293 318 300 300
query87 3613 3406 3427 3406
query88 2686 2261 2257 2257
query89 441 352 359 352
query90 1974 159 159 159
query91 155 128 127 127
query92 54 47 48 47
query93 965 523 458 458
query94 1141 178 178 178
query95 8608 359 8250 359
query96 587 271 263 263
query97 4424 4257 4309 4257
query98 209 204 198 198
query99 1027 765 753 753
Total cold run time: 280355 ms
Total hot run time: 179995 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934612742
<details>
<summary>TPC-H: <b>Total hot run time: 41638 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f881f65da74d8047b009fb7b0525a34526109f9, data reload: false
------ Round 1 ----------------------------------
q1 17631 5119 4932 4932
q2 2048 142 135 135
q3 10579 1052 1009 1009
q4 4650 978 990 978
q5 7693 3271 3265 3265
q6 197 137 129 129
q7 1284 808 768 768
q8 9250 2136 2089 2089
q9 7618 6758 6688 6688
q10 8347 2672 2662 2662
q11 418 207 228 207
q12 771 334 334 334
q13 17976 3690 3668 3668
q14 291 261 259 259
q15 606 521 505 505
q16 475 406 425 406
q17 957 912 848 848
q18 7393 6646 6659 6646
q19 1562 1499 1514 1499
q20 646 356 332 332
q21 6252 3930 3964 3930
q22 883 359 349 349
Total cold run time: 107527 ms
Total hot run time: 41638 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4847 4842 4868 4842
q2 301 188 185 185
q3 3626 3608 3620 3608
q4 2539 2524 2540 2524
q5 5785 5780 5763 5763
q6 211 124 123 123
q7 2254 1646 1668 1646
q8 3038 3142 3140 3140
q9 8778 8715 8712 8712
q10 6954 4297 4276 4276
q11 541 408 390 390
q12 767 554 540 540
q13 4240 3432 3394 3394
q14 264 232 249 232
q15 598 519 501 501
q16 485 448 427 427
q17 1749 1631 1614 1614
q18 8375 7626 7522 7522
q19 1648 1644 1647 1644
q20 2214 1884 1872 1872
q21 6683 6227 6204 6204
q22 584 496 524 496
Total cold run time: 66481 ms
Total hot run time: 59655 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934273109
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935596530
<details>
<summary>TPC-H: <b>Total hot run time: 41145 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9, data reload: false
------ Round 1 ----------------------------------
q1 17665 4925 4852 4852
q2 2047 136 141 136
q3 10579 1028 985 985
q4 4659 953 954 953
q5 7751 3176 3263 3176
q6 196 135 136 135
q7 1264 762 746 746
q8 9384 2095 2066 2066
q9 7576 6654 6664 6654
q10 8309 2652 2629 2629
q11 417 240 204 204
q12 760 334 329 329
q13 17993 3653 3657 3653
q14 294 255 256 255
q15 630 505 497 497
q16 470 399 414 399
q17 927 810 786 786
q18 7298 6724 6596 6596
q19 1551 1489 1487 1487
q20 614 334 341 334
q21 7065 3981 3930 3930
q22 866 351 343 343
Total cold run time: 108315 ms
Total hot run time: 41145 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4834 4830 4835 4830
q2 290 189 180 180
q3 3597 3576 3579 3576
q4 2533 2521 2513 2513
q5 5724 5736 5762 5736
q6 205 122 126 122
q7 2249 1661 1692 1661
q8 3027 3084 3126 3084
q9 8789 8792 8767 8767
q10 6839 4285 4278 4278
q11 524 396 424 396
q12 791 566 550 550
q13 4382 3433 3430 3430
q14 283 259 248 248
q15 592 514 507 507
q16 479 438 442 438
q17 1700 1633 1627 1627
q18 8476 7635 7679 7635
q19 1638 1639 1636 1636
q20 2116 1851 1847 1847
q21 6681 6360 6413 6360
q22 655 597 571 571
Total cold run time: 66404 ms
Total hot run time: 59992 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #30991:
URL: https://github.com/apache/doris/pull/30991#discussion_r1483299619
##########
be/src/agent/be_exec_version_manager.h:
##########
@@ -65,6 +65,7 @@ class BeExecVersionManager {
* d. unix_timestamp function support timestamp with float for datetimev2, and change nullable mode.
* e. change shuffle serialize/deserialize way
* f. the right function outputs NULL when the function contains NULL, substr function returns empty if start > str.length, and change some function nullable mode.
+ * g. function to_base64, from_base64 will return empty string when input empty string.
Review Comment:
please combine f and g to shorter words. just like "shrink some function's nullable mode"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934630345
<details>
<summary>TPC-DS: <b>Total hot run time: 180932 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f881f65da74d8047b009fb7b0525a34526109f9, data reload: false
query1 921 347 355 347
query2 6546 1795 1876 1795
query3 6702 215 210 210
query4 24916 22424 22537 22424
query5 4286 479 393 393
query6 272 172 171 171
query7 4608 295 304 295
query8 249 198 213 198
query9 8416 2812 2814 2812
query10 417 227 217 217
query11 16191 15652 15585 15585
query12 134 83 84 83
query13 1688 423 412 412
query14 9049 7853 7737 7737
query15 218 196 203 196
query16 7480 251 243 243
query17 1423 565 548 548
query18 1956 265 256 256
query19 185 141 150 141
query20 90 83 87 83
query21 184 122 118 118
query22 4941 4697 4823 4697
query23 32674 31598 31696 31598
query24 12658 3410 3403 3403
query25 654 362 363 362
query26 1864 162 161 161
query27 3044 318 325 318
query28 6633 1847 1830 1830
query29 1105 616 613 613
query30 288 137 149 137
query31 950 758 759 758
query32 93 61 57 57
query33 724 236 232 232
query34 1061 473 508 473
query35 936 815 819 815
query36 1000 897 902 897
query37 154 59 59 59
query38 3433 3283 3304 3283
query39 1378 1337 1324 1324
query40 282 102 107 102
query41 36 35 35 35
query42 104 99 101 99
query43 494 467 462 462
query44 1058 685 698 685
query45 200 180 175 175
query46 1087 778 756 756
query47 1663 1526 1546 1526
query48 424 351 353 351
query49 1227 301 302 301
query50 767 389 379 379
query51 5321 5163 5145 5145
query52 114 97 97 97
query53 393 291 308 291
query54 286 227 222 222
query55 87 83 82 82
query56 219 212 203 203
query57 1068 956 963 956
query58 222 208 199 199
query59 2541 2415 2222 2222
query60 246 231 215 215
query61 85 84 92 84
query62 600 388 403 388
query63 319 281 287 281
query64 6454 3132 3136 3132
query65 3302 3249 3255 3249
query66 1347 330 323 323
query67 14795 14298 14440 14298
query68 5086 542 559 542
query69 523 360 360 360
query70 1263 1236 1247 1236
query71 383 263 265 263
query72 6359 2788 2633 2633
query73 696 318 312 312
query74 7090 6637 6578 6578
query75 3181 2580 2544 2544
query76 3254 1115 1193 1115
query77 363 238 239 238
query78 9464 8837 8774 8774
query79 970 533 512 512
query80 523 364 351 351
query81 437 210 203 203
query82 163 88 82 82
query83 145 124 125 124
query84 222 77 75 75
query85 1032 351 339 339
query86 297 324 311 311
query87 3602 3410 3415 3410
query88 2703 2276 2283 2276
query89 455 366 358 358
query90 1952 163 161 161
query91 157 125 131 125
query92 59 52 48 48
query93 964 512 477 477
query94 1120 182 179 179
query95 8658 363 367 363
query96 569 261 266 261
query97 4438 4285 4261 4261
query98 236 198 190 190
query99 1071 757 692 692
Total cold run time: 281697 ms
Total hot run time: 180932 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934238599
<details>
<summary>ClickBench: <b>Total hot run time: 31.35 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2fb8693e3748879ca5d37f98b7146d69ccce050a, data reload: false
query1 0.03 0.02 0.02
query2 0.07 0.03 0.03
query3 0.24 0.07 0.07
query4 1.64 0.09 0.09
query5 0.49 0.48 0.48
query6 1.37 0.63 0.62
query7 0.02 0.01 0.02
query8 0.04 0.03 0.03
query9 0.54 0.45 0.44
query10 0.49 0.50 0.50
query11 0.13 0.10 0.09
query12 0.12 0.10 0.10
query13 0.59 0.60 0.58
query14 0.76 0.80 0.77
query15 0.81 0.80 0.80
query16 0.33 0.34 0.32
query17 0.92 0.91 0.90
query18 0.19 0.18 0.17
query19 1.78 1.70 1.65
query20 0.01 0.01 0.02
query21 15.39 0.68 0.58
query22 3.36 3.77 2.51
query23 17.60 1.04 0.97
query24 2.14 0.42 0.75
query25 0.60 0.07 0.06
query26 0.16 0.15 0.15
query27 0.06 0.05 0.05
query28 11.56 0.83 0.82
query29 12.56 3.51 3.43
query30 0.53 0.50 0.51
query31 2.78 0.35 0.36
query32 3.33 0.48 0.47
query33 3.11 3.14 3.09
query34 15.36 4.53 4.53
query35 4.50 4.51 4.52
query36 1.07 0.94 0.94
query37 0.07 0.05 0.06
query38 0.04 0.03 0.03
query39 0.03 0.01 0.02
query40 0.17 0.15 0.14
query41 0.07 0.02 0.02
query42 0.02 0.02 0.02
query43 0.03 0.02 0.02
Total cold run time: 105.11 s
Total hot run time: 31.35 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935553649
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934383266
<details>
<summary>TPC-H: <b>Total hot run time: 41420 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60e81e94379af7d292ae65da66593242adf9e7f4, data reload: false
------ Round 1 ----------------------------------
q1 17694 4920 4852 4852
q2 2050 154 134 134
q3 10609 1064 995 995
q4 4748 957 968 957
q5 7737 3222 3274 3222
q6 191 136 132 132
q7 1272 774 777 774
q8 9387 2106 2091 2091
q9 7581 6679 6679 6679
q10 8611 2665 2651 2651
q11 419 215 207 207
q12 768 321 331 321
q13 18004 3697 3669 3669
q14 292 271 261 261
q15 623 508 507 507
q16 473 403 436 403
q17 932 887 870 870
q18 7434 6640 6589 6589
q19 1566 1504 1509 1504
q20 602 363 323 323
q21 6727 3945 3945 3945
q22 873 354 334 334
Total cold run time: 108593 ms
Total hot run time: 41420 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4834 4811 4810 4810
q2 294 182 184 182
q3 3598 3587 3592 3587
q4 2524 2516 2534 2516
q5 5729 5748 5745 5745
q6 209 125 121 121
q7 2234 1633 1617 1617
q8 3043 3121 3117 3117
q9 8706 8732 8705 8705
q10 6836 4254 4228 4228
q11 537 380 389 380
q12 775 528 544 528
q13 4277 3413 3419 3413
q14 265 253 227 227
q15 599 532 507 507
q16 476 440 432 432
q17 1693 1614 1626 1614
q18 8321 7614 7674 7614
q19 1641 1644 1642 1642
q20 2140 1875 1830 1830
q21 6589 6174 6136 6136
q22 569 505 517 505
Total cold run time: 65889 ms
Total hot run time: 59456 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934643126
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4f881f65da74d8047b009fb7b0525a34526109f9 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934244660
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 2fb8693e3748879ca5d37f98b7146d69ccce050a with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.6 seconds inserted 10000000 Rows, about 735K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1933455730
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1933457915
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30991:
URL: https://github.com/apache/doris/pull/30991#discussion_r1482486267
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -756,7 +879,89 @@ struct ToBase64Impl {
}
};
-struct FromBase64Impl {
+class FunctionFromBase64 : public IFunction {
+public:
+ static constexpr auto name = "from_base64";
+
+ using ReturnType = DataTypeString;
+ using ColumnType = ColumnString;
+
+ static FunctionPtr create() { return std::make_shared<FunctionFromBase64>(); }
+
+ String get_name() const override { return name; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
Review Comment:
warning: method 'get_return_type_impl' can be made static [readability-convert-member-functions-to-static]
```suggestion
static DataTypePtr get_return_type_impl(const DataTypes& arguments) override {
```
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -756,7 +879,89 @@
}
};
-struct FromBase64Impl {
+class FunctionFromBase64 : public IFunction {
+public:
+ static constexpr auto name = "from_base64";
+
+ using ReturnType = DataTypeString;
+ using ColumnType = ColumnString;
+
+ static FunctionPtr create() { return std::make_shared<FunctionFromBase64>(); }
+
+ String get_name() const override { return name; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ return make_nullable(std::make_shared<ReturnType>());
+ }
+
+ bool use_default_implementation_for_nulls() const override { return true; }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override {
Review Comment:
warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
```suggestion
static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934139312
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935623578
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.7 seconds inserted 10000000 Rows, about 729K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935595836
TeamCity be ut coverage result:
Function Coverage: 35.85% (8560/23875)
Line Coverage: 27.78% (69461/250079)
Region Coverage: 26.91% (36036/133915)
Branch Coverage: 23.68% (18419/77770)
Coverage Report: http://coverage.selectdb-in.cc/coverage/47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9_47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935619377
<details>
<summary>ClickBench: <b>Total hot run time: 30.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9, data reload: false
query1 0.04 0.03 0.02
query2 0.06 0.02 0.03
query3 0.23 0.08 0.08
query4 1.63 0.09 0.10
query5 0.48 0.47 0.48
query6 1.34 0.62 0.69
query7 0.02 0.01 0.02
query8 0.04 0.03 0.03
query9 0.54 0.43 0.46
query10 0.48 0.49 0.49
query11 0.13 0.10 0.09
query12 0.12 0.10 0.10
query13 0.59 0.58 0.58
query14 0.76 0.79 0.79
query15 0.82 0.79 0.78
query16 0.34 0.32 0.32
query17 0.89 0.89 0.91
query18 0.18 0.19 0.15
query19 1.72 1.67 1.68
query20 0.01 0.01 0.01
query21 15.39 0.67 0.60
query22 3.05 4.04 2.08
query23 17.45 1.01 0.95
query24 1.95 0.60 0.37
query25 0.64 0.07 0.06
query26 0.14 0.14 0.13
query27 0.07 0.05 0.06
query28 12.04 0.81 0.80
query29 12.58 3.37 3.37
query30 0.55 0.48 0.48
query31 2.78 0.35 0.35
query32 3.37 0.48 0.47
query33 3.14 3.13 3.10
query34 15.34 4.51 4.50
query35 4.49 4.50 4.52
query36 1.04 0.95 0.94
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.01
query40 0.17 0.14 0.15
query41 0.07 0.02 0.02
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 104.86 s
Total hot run time: 30.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934105632
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "koarz (via GitHub)" <gi...@apache.org>.
koarz commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934287102
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934405989
<details>
<summary>TPC-DS: <b>Total hot run time: 180865 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60e81e94379af7d292ae65da66593242adf9e7f4, data reload: false
query1 936 345 345 345
query2 6536 1800 1843 1800
query3 6700 216 211 211
query4 24579 22473 22467 22467
query5 4302 384 378 378
query6 260 170 170 170
query7 4605 298 301 298
query8 249 196 194 194
query9 8427 2800 2778 2778
query10 412 231 215 215
query11 16186 15538 15521 15521
query12 142 82 86 82
query13 1717 418 417 417
query14 9140 7879 7698 7698
query15 213 184 184 184
query16 7465 258 254 254
query17 1419 562 550 550
query18 1964 272 263 263
query19 190 145 147 145
query20 87 83 83 83
query21 189 126 120 120
query22 5076 4880 4681 4681
query23 32474 31581 31532 31532
query24 12793 3434 3425 3425
query25 647 369 372 369
query26 1822 154 155 154
query27 3059 315 323 315
query28 6605 1824 1821 1821
query29 1131 620 608 608
query30 274 135 144 135
query31 953 760 781 760
query32 92 61 54 54
query33 740 236 233 233
query34 1053 483 505 483
query35 941 837 829 829
query36 986 892 850 850
query37 135 68 62 62
query38 3420 3324 3341 3324
query39 1395 1321 1315 1315
query40 280 108 103 103
query41 36 34 35 34
query42 105 103 97 97
query43 482 456 465 456
query44 1074 690 703 690
query45 208 179 181 179
query46 1030 788 768 768
query47 1686 1573 1550 1550
query48 418 351 350 350
query49 1198 310 300 300
query50 768 367 371 367
query51 5332 5167 5176 5167
query52 108 96 95 95
query53 398 306 301 301
query54 306 222 227 222
query55 85 81 82 81
query56 212 200 206 200
query57 1062 970 984 970
query58 220 191 205 191
query59 2370 2159 2277 2159
query60 246 229 226 226
query61 85 85 83 83
query62 601 376 386 376
query63 322 281 287 281
query64 6422 3083 3111 3083
query65 3301 3268 3234 3234
query66 1332 332 325 325
query67 14401 14530 14272 14272
query68 5074 561 564 561
query69 520 359 363 359
query70 1243 1237 1217 1217
query71 393 261 255 255
query72 6379 2777 2631 2631
query73 691 317 321 317
query74 7132 6660 6633 6633
query75 3212 2562 2545 2545
query76 3309 1130 1189 1130
query77 345 242 232 232
query78 9389 8868 8970 8868
query79 983 519 513 513
query80 525 365 347 347
query81 439 207 198 198
query82 159 80 82 80
query83 143 124 121 121
query84 225 78 76 76
query85 1028 348 340 340
query86 290 300 321 300
query87 3609 3422 3423 3422
query88 2759 2293 2294 2293
query89 437 354 362 354
query90 1926 161 164 161
query91 151 126 131 126
query92 53 50 50 50
query93 1000 498 509 498
query94 1096 180 185 180
query95 479 385 372 372
query96 571 262 264 262
query97 4441 4238 4259 4238
query98 208 209 197 197
query99 1067 716 706 706
Total cold run time: 272678 ms
Total hot run time: 180865 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934423774
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 60e81e94379af7d292ae65da66593242adf9e7f4 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934638549
<details>
<summary>ClickBench: <b>Total hot run time: 31.6 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4f881f65da74d8047b009fb7b0525a34526109f9, data reload: false
query1 0.03 0.02 0.02
query2 0.07 0.03 0.03
query3 0.22 0.07 0.07
query4 1.65 0.08 0.09
query5 0.49 0.48 0.48
query6 1.44 0.61 0.72
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.54 0.46 0.45
query10 0.50 0.50 0.52
query11 0.13 0.10 0.10
query12 0.12 0.09 0.10
query13 0.60 0.59 0.58
query14 0.79 0.77 0.80
query15 0.82 0.79 0.80
query16 0.35 0.34 0.33
query17 0.91 0.90 0.94
query18 0.19 0.18 0.15
query19 1.75 1.67 1.69
query20 0.01 0.01 0.02
query21 15.39 0.68 0.60
query22 3.16 4.33 3.05
query23 17.40 1.04 1.08
query24 2.01 0.74 0.22
query25 0.58 0.06 0.05
query26 0.18 0.14 0.14
query27 0.07 0.05 0.04
query28 12.02 0.83 0.80
query29 12.75 3.32 3.30
query30 0.51 0.50 0.47
query31 2.78 0.36 0.36
query32 3.38 0.48 0.48
query33 3.14 3.16 3.14
query34 15.37 4.51 4.50
query35 4.54 4.50 4.50
query36 1.09 0.96 0.96
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.01
query40 0.17 0.15 0.17
query41 0.07 0.02 0.02
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.46 s
Total hot run time: 31.6 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934626768
TeamCity be ut coverage result:
Function Coverage: 35.84% (8560/23881)
Line Coverage: 27.77% (69467/250140)
Region Coverage: 26.90% (36035/133942)
Branch Coverage: 23.69% (18424/77784)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4f881f65da74d8047b009fb7b0525a34526109f9_4f881f65da74d8047b009fb7b0525a34526109f9/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1935611634
<details>
<summary>TPC-DS: <b>Total hot run time: 180505 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9, data reload: false
query1 2816 363 351 351
query2 7609 1877 1766 1766
query3 9104 224 218 218
query4 25950 22475 22444 22444
query5 4747 385 384 384
query6 280 177 165 165
query7 4610 299 300 299
query8 253 213 213 213
query9 8444 2789 2783 2783
query10 432 232 218 218
query11 16115 15574 15574 15574
query12 153 81 85 81
query13 1728 418 418 418
query14 11084 7586 7678 7586
query15 215 185 193 185
query16 7595 262 250 250
query17 1697 573 540 540
query18 2118 268 268 268
query19 202 149 148 148
query20 91 88 91 88
query21 184 126 123 123
query22 4936 4883 4799 4799
query23 32487 31511 31568 31511
query24 11202 3435 3436 3435
query25 618 367 362 362
query26 1633 150 153 150
query27 3056 319 325 319
query28 6571 1804 1805 1804
query29 1095 610 625 610
query30 277 136 147 136
query31 941 763 761 761
query32 97 60 53 53
query33 726 231 231 231
query34 1071 494 511 494
query35 945 816 815 815
query36 968 893 831 831
query37 132 63 61 61
query38 3466 3320 3311 3311
query39 1368 1339 1304 1304
query40 277 105 102 102
query41 37 35 32 32
query42 102 99 99 99
query43 478 452 461 452
query44 1059 684 699 684
query45 200 188 176 176
query46 1048 759 741 741
query47 1655 1587 1547 1547
query48 419 341 353 341
query49 1158 315 300 300
query50 779 408 386 386
query51 5267 5145 5156 5145
query52 112 92 94 92
query53 394 299 305 299
query54 292 229 241 229
query55 81 85 78 78
query56 224 204 199 199
query57 1044 927 998 927
query58 223 203 211 203
query59 2416 2197 2222 2197
query60 243 221 212 212
query61 84 84 83 83
query62 591 367 400 367
query63 334 291 284 284
query64 6344 3026 3128 3026
query65 3301 3237 3245 3237
query66 1215 324 333 324
query67 14490 14172 14474 14172
query68 4646 543 560 543
query69 484 359 355 355
query70 1245 1210 1237 1210
query71 354 257 256 256
query72 6376 2770 2631 2631
query73 686 310 316 310
query74 7056 6604 6554 6554
query75 3151 2578 2574 2574
query76 3081 1138 1199 1138
query77 348 245 241 241
query78 9449 8804 8777 8777
query79 988 506 516 506
query80 595 357 350 350
query81 439 208 201 201
query82 328 85 87 85
query83 148 132 123 123
query84 234 76 76 76
query85 1166 340 335 335
query86 310 298 314 298
query87 3612 3429 3468 3429
query88 2679 2308 2275 2275
query89 457 348 360 348
query90 2071 164 165 164
query91 164 129 128 128
query92 54 46 50 46
query93 1056 514 513 513
query94 1448 178 181 178
query95 486 379 8738 379
query96 582 264 264 264
query97 4453 4253 4280 4253
query98 225 207 200 200
query99 1061 742 755 742
Total cold run time: 280315 ms
Total hot run time: 180505 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934203257
<details>
<summary>TPC-H: <b>Total hot run time: 41452 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2fb8693e3748879ca5d37f98b7146d69ccce050a, data reload: false
------ Round 1 ----------------------------------
q1 17619 5027 4895 4895
q2 2044 140 134 134
q3 10664 1074 1005 1005
q4 4730 978 986 978
q5 7757 3236 3281 3236
q6 197 138 140 138
q7 1274 778 782 778
q8 9424 2077 2061 2061
q9 7710 6691 6671 6671
q10 8371 2672 2646 2646
q11 424 218 213 213
q12 746 326 332 326
q13 18006 3712 3711 3711
q14 294 259 261 259
q15 582 529 507 507
q16 506 411 422 411
q17 943 881 856 856
q18 7096 6561 6563 6561
q19 1542 1493 1486 1486
q20 559 331 334 331
q21 6115 3950 3919 3919
q22 655 354 330 330
Total cold run time: 107258 ms
Total hot run time: 41452 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4867 4857 4828 4828
q2 290 178 176 176
q3 3612 3599 3587 3587
q4 2511 2503 2499 2499
q5 5738 5739 5740 5739
q6 208 127 130 127
q7 2240 1640 1674 1640
q8 2984 3054 3073 3054
q9 8690 8664 8641 8641
q10 4962 4217 4218 4217
q11 516 356 358 356
q12 763 540 566 540
q13 4143 3401 3360 3360
q14 274 228 245 228
q15 637 509 507 507
q16 472 433 434 433
q17 1649 1581 1586 1581
q18 8275 7516 7602 7516
q19 1635 1640 1640 1640
q20 2104 1814 1812 1812
q21 6494 6111 6116 6111
q22 569 495 514 495
Total cold run time: 63633 ms
Total hot run time: 59087 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](function) change some function nullable mode [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30991:
URL: https://github.com/apache/doris/pull/30991#issuecomment-1934417567
<details>
<summary>ClickBench: <b>Total hot run time: 30.22 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60e81e94379af7d292ae65da66593242adf9e7f4, data reload: false
query1 0.03 0.02 0.02
query2 0.07 0.02 0.02
query3 0.22 0.07 0.08
query4 1.67 0.09 0.08
query5 0.49 0.49 0.48
query6 1.38 0.61 0.60
query7 0.02 0.02 0.02
query8 0.05 0.02 0.02
query9 0.52 0.44 0.44
query10 0.47 0.48 0.47
query11 0.12 0.09 0.09
query12 0.12 0.10 0.10
query13 0.59 0.59 0.59
query14 0.75 0.80 0.78
query15 0.81 0.81 0.78
query16 0.32 0.32 0.34
query17 0.88 0.88 0.87
query18 0.17 0.17 0.16
query19 1.66 1.66 1.62
query20 0.01 0.01 0.01
query21 15.40 0.64 0.59
query22 3.32 3.74 2.01
query23 17.59 1.01 0.97
query24 2.01 0.74 0.13
query25 0.52 0.07 0.05
query26 0.16 0.14 0.14
query27 0.05 0.05 0.05
query28 12.22 0.83 0.82
query29 12.58 3.32 3.26
query30 0.53 0.50 0.47
query31 2.78 0.35 0.36
query32 3.35 0.48 0.48
query33 3.11 3.12 3.13
query34 15.36 4.54 4.52
query35 4.55 4.50 4.51
query36 1.08 0.94 0.93
query37 0.08 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.02
query40 0.17 0.15 0.15
query41 0.08 0.01 0.01
query42 0.02 0.02 0.01
query43 0.02 0.02 0.02
Total cold run time: 105.39 s
Total hot run time: 30.22 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org