You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "misha-codethink (via GitHub)" <gi...@apache.org> on 2024/05/16 09:52:00 UTC

[PR] Update documentation for installing Buildbox [buildstream]

misha-codethink opened a new pull request, #1919:
URL: https://github.com/apache/buildstream/pull/1919

   Buildbox repositories have been merged into one, so the installation documentation needs updating.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update documentation for installing Buildbox [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim merged PR #1919:
URL: https://github.com/apache/buildstream/pull/1919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update documentation for installing Buildbox [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on code in PR #1919:
URL: https://github.com/apache/buildstream/pull/1919#discussion_r1603065707


##########
doc/source/main_install.rst:
##########
@@ -117,26 +117,10 @@ e.g., ``~/.local/bin``.
 Build from source
 ~~~~~~~~~~~~~~~~~
 
-Each of the 4 buildbox components can be installed separately from their
-respective git repositiories, and each respository has individual install
-instructions. We recommend installing the latest release tag of each
-component.
-
-| **Buildbox-common:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-common/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-casd:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-casd/-/blob/master/README.rst \
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-fuse:** See
-| https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/-/blob/master/INSTALL.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-run-bublewrap:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-run-bubblewrap/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
+Buildbox components can be installed from their git
+We recommend installing from the latest release tag.

Review Comment:
   I think it's worth mentioning that we recommend -casd, -fuse and -run-bubblewrap and that the rest can be disabled when building.



##########
doc/source/main_install.rst:
##########
@@ -117,26 +117,10 @@ e.g., ``~/.local/bin``.
 Build from source
 ~~~~~~~~~~~~~~~~~
 
-Each of the 4 buildbox components can be installed separately from their
-respective git repositiories, and each respository has individual install
-instructions. We recommend installing the latest release tag of each
-component.
-
-| **Buildbox-common:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-common/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-casd:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-casd/-/blob/master/README.rst \
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-fuse:** See
-| https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/-/blob/master/INSTALL.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-run-bublewrap:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-run-bubblewrap/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
+Buildbox components can be installed from their git

Review Comment:
   This sounds like an incomplete sentence.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update documentation for installing Buildbox [buildstream]

Posted by "misha-codethink (via GitHub)" <gi...@apache.org>.
misha-codethink commented on code in PR #1919:
URL: https://github.com/apache/buildstream/pull/1919#discussion_r1603094103


##########
doc/source/main_install.rst:
##########
@@ -117,26 +117,10 @@ e.g., ``~/.local/bin``.
 Build from source
 ~~~~~~~~~~~~~~~~~
 
-Each of the 4 buildbox components can be installed separately from their
-respective git repositiories, and each respository has individual install
-instructions. We recommend installing the latest release tag of each
-component.
-
-| **Buildbox-common:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-common/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-casd:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-casd/-/blob/master/README.rst \
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-fuse:** See
-| https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/-/blob/master/INSTALL.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-run-bublewrap:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-run-bubblewrap/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
+Buildbox components can be installed from their git

Review Comment:
   Amended.



##########
doc/source/main_install.rst:
##########
@@ -117,26 +117,10 @@ e.g., ``~/.local/bin``.
 Build from source
 ~~~~~~~~~~~~~~~~~
 
-Each of the 4 buildbox components can be installed separately from their
-respective git repositiories, and each respository has individual install
-instructions. We recommend installing the latest release tag of each
-component.
-
-| **Buildbox-common:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-common/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-casd:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-casd/-/blob/master/README.rst \
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-fuse:** See
-| https://gitlab.com/BuildGrid/buildbox/buildbox-fuse/-/blob/master/INSTALL.rst
-| (Be sure to install from the latest stable release tag.)
-
-| **Buildbox-run-bublewrap:** See the installation section in:
-| https://gitlab.com/BuildGrid/buildbox/buildbox-run-bubblewrap/-/blob/master/README.rst
-| (Be sure to install from the latest stable release tag.)
+Buildbox components can be installed from their git
+We recommend installing from the latest release tag.

Review Comment:
   Amended.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org