You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/09 07:32:02 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #9538: Fix treading metrics will always get stuck in some cases

315157973 opened a new pull request #9538:
URL: https://github.com/apache/pulsar/pull/9538


   ### Motivation
   When `javaInstanceRunnable` has not been initialized yet, and client calls `FunctionsStatsGenerator#generate`, the NPE will be triggered.
   Since only IOException is captured here, the client's request will be blocked all the time.
   
   The following unit tests are affected and often fail:
   `org.apache.pulsar.io.PulsarFunctionE2ETest#testReadCompactedSink`
   
   ### Modifications
   Catch all exceptions
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #9538: Fix reading metrics will always get stuck in some cases

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9538:
URL: https://github.com/apache/pulsar/pull/9538#issuecomment-775746990


   > This fix is okay for me
   > 
   > Be can we also fix the NPE ?
   > do you have a stacktrace ?
   > 
   > if we do not fix the NPE now we will forget about it
   > a NullPointerException is always a bug and must be fixed.
   
   This situation will occur when Function startup is not completely finished.But at this time there is a client request.
   Even if NPE is not thrown, other exceptions must be thrown.
   The status received by the client is all 500, there is no big difference.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9538: Fix reading metrics will always get stuck in some cases

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9538:
URL: https://github.com/apache/pulsar/pull/9538


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org