You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "visortelle (via GitHub)" <gi...@apache.org> on 2023/05/24 07:42:15 UTC
[GitHub] [pulsar-site] visortelle opened a new pull request, #585: After Pulsar Virtual Summit Europe 2023 is over
visortelle opened a new pull request, #585:
URL: https://github.com/apache/pulsar-site/pull/585
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
-->
<!-- Either this PR adds a doc for a code PR, -->
This PR adds doc for #xyz
<!-- or fixes a doc issue -->
This PR fixes #xyz
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
- Removed the announcement bar.
- Added Pulsar Summit Europe 2023 to the events list.
- Changed Featured Event block text.
<img width="1440" alt="Screenshot 2023-05-24 at 9 41 42 AM" src="https://github.com/apache/pulsar-site/assets/9302460/bb110892-30ce-4120-b984-f40d34c38478">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #585: After Pulsar Virtual Summit Europe 2023
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #585:
URL: https://github.com/apache/pulsar-site/pull/585#discussion_r1204544920
##########
docusaurus.config.js:
##########
@@ -142,16 +142,16 @@ module.exports = {
trailingSlash: true,
themeConfig: {
/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
- announcementBar: {
- id: "summit",
- content: renderAnnouncementBar(
- "Pulsar Virtual Summit Europe 2023",
- "https://pulsar-summit.org/event/europe-2023"
- ),
- backgroundColor: "#282826",
- textColor: "#fff",
- isCloseable: false,
- },
+ // announcementBar: {
Review Comment:
thought - perhaps we can develop a default announcementBar later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on a diff in pull request #585: After Pulsar Virtual Summit Europe 2023
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #585:
URL: https://github.com/apache/pulsar-site/pull/585#discussion_r1204822235
##########
docusaurus.config.js:
##########
@@ -142,16 +142,16 @@ module.exports = {
trailingSlash: true,
themeConfig: {
/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
- announcementBar: {
- id: "summit",
- content: renderAnnouncementBar(
- "Pulsar Virtual Summit Europe 2023",
- "https://pulsar-summit.org/event/europe-2023"
- ),
- backgroundColor: "#282826",
- textColor: "#fff",
- isCloseable: false,
- },
+ // announcementBar: {
Review Comment:
If you have a concrete suggestion of how it should work, I can implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #585: After Pulsar Virtual Summit Europe 2023
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #585:
URL: https://github.com/apache/pulsar-site/pull/585#discussion_r1204903820
##########
docusaurus.config.js:
##########
@@ -142,16 +142,16 @@ module.exports = {
trailingSlash: true,
themeConfig: {
/** @type {import('@docusaurus/preset-classic').ThemeConfig} */
- announcementBar: {
- id: "summit",
- content: renderAnnouncementBar(
- "Pulsar Virtual Summit Europe 2023",
- "https://pulsar-summit.org/event/europe-2023"
- ),
- backgroundColor: "#282826",
- textColor: "#fff",
- isCloseable: false,
- },
+ // announcementBar: {
Review Comment:
I don't know, lol.
Other projects may set a banner for "star me", but I don't think it's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun merged pull request #585: After Pulsar Virtual Summit Europe 2023
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #585:
URL: https://github.com/apache/pulsar-site/pull/585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org