You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/03/10 09:02:24 UTC

Review Request 18951: Simplified future await latch semantics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18951/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos-git


Description
-------

Simplify.


Diffs
-----

  3rdparty/libprocess/include/process/future.hpp 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 

Diff: https://reviews.apache.org/r/18951/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 18951: Simplified future await latch semantics.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18951/#review37259
-----------------------------------------------------------

Ship it!


Ship It!

- Jiang Yan Xu


On March 10, 2014, 1:02 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18951/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 1:02 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Simplify.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 
> 
> Diff: https://reviews.apache.org/r/18951/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 18951: Simplified future await latch semantics.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18951/#review37404
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On March 10, 2014, 8:02 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18951/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 8:02 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Simplify.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 
> 
> Diff: https://reviews.apache.org/r/18951/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 18951: Simplified future await latch semantics.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18951/#review37251
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 10, 2014, 8:02 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18951/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 8:02 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Simplify.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 
> 
> Diff: https://reviews.apache.org/r/18951/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 18951: Simplified future await latch semantics.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18951/#review36639
-----------------------------------------------------------


Bad patch!

Reviews applied: [18951]

Failed command: git apply --index 18951.patch

Error:
 error: patch failed: 3rdparty/libprocess/include/process/future.hpp:13
error: 3rdparty/libprocess/include/process/future.hpp: patch does not apply


- Mesos ReviewBot


On March 10, 2014, 8:02 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18951/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 8:02 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Simplify.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 
> 
> Diff: https://reviews.apache.org/r/18951/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>