You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/06/05 13:54:05 UTC
[GitHub] [servicecomb-java-chassis] fu-turer opened a new pull request, #3035: [SCB-2544]Use protobuf-maven-plugin generat java class in foundation-…
fu-turer opened a new pull request, #3035:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3035
### Motivation
Remove protoc generated java sources file, and use protobuf-maven-plugin generate when complie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3035: [SCB-2544]Use protobuf-maven-plugin generat java class in foundation-…
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3035:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3035#discussion_r889696108
##########
foundations/foundation-protobuf/pom.xml:
##########
@@ -67,4 +67,34 @@
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <version>${protobuf-maven-plugin.version}</version>
+ <configuration>
+ <protocArtifact>com.google.protobuf:protoc:${protoc3-maven-plugin.version}:exe:${os.detected.classifier}</protocArtifact>
+ <checkStaleness>true</checkStaleness>
+ <pluginId>grpc-java</pluginId>
+ <pluginArtifact>io.grpc:protoc-gen-grpc-java:${protoc-gen-grpc-java-plugin.version}:exe:${os.detected.classifier}</pluginArtifact>
+ <protoTestSourceRoot>src/test/resources</protoTestSourceRoot>
+ <excludes>
+ <exclude>**/jacksonRoot.proto</exclude>
+ <exclude>**/method.proto</exclude>
+ <exclude>**/model.proto</exclude>
+ </excludes>
+ </configuration>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>test-compile</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
</project>
Review Comment:
better to add new line on the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj merged pull request #3035: [SCB-2544]Use protobuf-maven-plugin generat java class in foundation-protobuf
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3035:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3035: [SCB-2544]Use protobuf-maven-plugin generat java class in foundation-…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3035:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3035#issuecomment-1146813631
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3035](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7379189) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/1f025588f834d425ddd373e3fc18b310bef8f036?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f02558) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7379189 differs from pull request most recent head 32cba8b. Consider uploading reports for the commit 32cba8b to get more accurate results
```diff
@@ Coverage Diff @@
## master #3035 +/- ##
=========================================
Coverage 77.60% 77.61%
Complexity 1415 1415
=========================================
Files 1611 1611
Lines 43091 43091
Branches 3630 3630
=========================================
+ Hits 33441 33444 +3
+ Misses 8150 8147 -3
Partials 1500 1500
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.86% <0.00%> (+1.08%)` | :arrow_up: |
| [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `77.41% <0.00%> (+6.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f02558...32cba8b](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3035?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org