You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nikam14 (via GitHub)" <gi...@apache.org> on 2023/05/04 10:04:25 UTC
[GitHub] [eventmesh] nikam14 opened a new pull request, #3866: [ISUUE#3011][Enhancement] Method manually handles closing an auto-closeable resource [TCPClientHandler]
nikam14 opened a new pull request, #3866:
URL: https://github.com/apache/eventmesh/pull/3866
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3011 .
### Motivation
This method allocates and uses an auto closeable resource. However, it manually closes the resource in a finally block. While this is correct management, it doesn't rely on the idiomatic way available to JDK 7 and above, allows for possible subtle problems, and complicates the reading of code by developers
### Modifications
use of try-with-resources.
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3866: [ISSUE #3011] Method manually handles closing an auto-closeable resource [TCPClientHandler]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3866:
URL: https://github.com/apache/eventmesh/pull/3866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3866: [ISUUE#3011][Enhancement] Method manually handles closing an auto-closeable resource [TCPClientHandler]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3866:
URL: https://github.com/apache/eventmesh/pull/3866#issuecomment-1535832229
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3866?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3866](https://app.codecov.io/gh/apache/eventmesh/pull/3866?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f4075c) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/c5b7cf44e526f01016e2f05af7fde3e7c0534462?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5b7cf4) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1f4075c differs from pull request most recent head 41aecdc. Consider uploading reports for the commit 41aecdc to get more accurate results
```diff
@@ Coverage Diff @@
## master #3866 +/- ##
============================================
- Coverage 13.81% 13.80% -0.01%
Complexity 1291 1291
============================================
Files 571 571
Lines 29090 29075 -15
Branches 2841 2827 -14
============================================
- Hits 4019 4015 -4
+ Misses 24698 24688 -10
+ Partials 373 372 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3866?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntmesh/runtime/admin/handler/TCPClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3866?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVENQQ2xpZW50SGFuZGxlci5qYXZh) | `4.65% <0.00%> (+0.39%)` | :arrow_up: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3866/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org