[jira] [Resolved] (AMQ-5099) Useless or dead code in OpenWireFormat class.

["Kevin Earls (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Earls resolved AMQ-5099.
------------------------------

    Resolution: Fixed

> Useless or dead code in OpenWireFormat class.
> ---------------------------------------------
>
>                 Key: AMQ-5099
>                 URL: https://issues.apache.org/jira/browse/AMQ-5099
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 5.9.0
>            Reporter: Yuriy Sidelnikov
>            Assignee: Kevin Earls
>            Priority: Minor
>
> Method marshal has following code:
>         ByteSequence sequence = null;
>         // if( ma!=null ) {
>         // sequence = ma.getCachedMarshalledForm(this);
>         // }
>         if (sequence == null) {
>        ....
> It makes no sense to check if sequence is null because it is set to null couple of lines above and possible value change is commented. It would be better to comment the check or remove both check and commented lines.



--
This message was sent by Atlassian JIRA
(v6.2#6252)