Re: [PR] HIVE-29559: materializeCTE to query Analyzer from DDLSemanticAnalyzerFactory [hive]

["konstantinb (via GitHub)" <gi...@apache.org>]

konstantinb commented on PR #6423:
URL: https://github.com/apache/hive/pull/6423#issuecomment-4425811655

   Hi @kasakrisz — hope you're doing well. Just circling back on this one.
   
     I've addressed your review feedback in f957fc84:
     - Unit test simplified (threshold lowered to 1, simpler query)
     - `.q` file reduced to a single test case that reproduces the NPE via the CBO ALWAYS-fallback path
   
     Regarding your question about whether the `.q` file is necessary at all — I'm happy either way. If you'd prefer I remove it entirely and rely solely on the unit
      test, just let me know and I'll update the PR accordingly. Otherwise it's ready as-is.
   
     @deniskuzZ — if you have bandwidth to take another look as well, that would be appreciated.
   
     No rush on either of you — just wanted to make sure this hadn't fallen off the radar. Thanks for your time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org