You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Tim Bacon (JIRA)" <ji...@apache.org> on 2013/05/09 12:35:16 UTC
[jira] [Comment Edited] (FLUME-2015) ElasticSearchSink: need access
to IndexRequestBuilder instance during flume event processing
[ https://issues.apache.org/jira/browse/FLUME-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652837#comment-13652837 ]
Tim Bacon edited comment on FLUME-2015 at 5/9/13 10:33 AM:
-----------------------------------------------------------
Mike, thanks for the review.
I don't think there is a need for a separate interface because (as I said on the RB) the new return type is the interface from which the old return type is subclassed. Hope you agree?!
There is one further change that I would like to make however: the new interface does not currently extend {{Configurable}} / {{ConfigurableComponent}}. I have attached a standalone patch [https://issues.apache.org/jira/secure/attachment/12582445/FLUME-2015-1.4.0-01.patch] that contains this new change, and a cumulative patch [https://issues.apache.org/jira/secure/attachment/12582444/FLUME-2015-1.4.0-1.patch] that contains both the additional and prior changes.
Please let me know if you would like this additional patch to go through the RB as well.
was (Author: prime8):
Mike, thanks for the review.
I don't think there is a need for a separate interface because (as I said on the RB) the new return type is the interface from which the old return type is subclassed. Hope you agree?!
There is one further change that I would like to make however: the new interface does not currently extend {{Configurable}} / {{ConfigurableComponent}}. I have attached a standalone patch [https://issues.apache.org/jira/secure/attachment/12582437/FLUME-2015-1.4.0-01.patch] that contains this new change, and a cumulative patch [https://issues.apache.org/jira/secure/attachment/12582438/FLUME-2015-1.4.0-1.patch] that contains both the additional and prior changes.
Please let me know if you would like this additional patch to go through the RB as well.
> ElasticSearchSink: need access to IndexRequestBuilder instance during flume event processing
> --------------------------------------------------------------------------------------------
>
> Key: FLUME-2015
> URL: https://issues.apache.org/jira/browse/FLUME-2015
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.3.0, v1.3.1
> Reporter: Tim Bacon
> Attachments: FLUME-2015-1.4.0-01.patch, FLUME-2015-1.4.0-0.patch, FLUME-2015-1.4.0-1.patch, FLUME-2015-doc-1.4.0-0.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> I need more control over the indexing performed by the {{ElasticSearchSink}} -- in particular I need access to an {{IndexRequestBuilder}} instance during flume event processing. The interactions between {{ElasticSearchSink}} and {{ElasticSearchEventSerializer}} currently do not make this possible.
> I have authored a patch that meets my needs and maintains backwards-compatibility for existing users of the sink. It is available at [https://github.com/prime8/flume/commit/1056c129b10c95cee50e0c3f77e309668f82bfc6] -- please let me know if it can be pulled into the main ASF source tree!
> Thanks :-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira