[GitHub] [airflow] subkanthi commented on a change in pull request #20505: 20496 fix port standalone mode

[GitBox <gi...@apache.org>]

subkanthi commented on a change in pull request #20505:
URL: https://github.com/apache/airflow/pull/20505#discussion_r775261387



##########
File path: airflow/cli/commands/standalone_command.py
##########
@@ -206,7 +208,7 @@ def is_ready(self):
         Detects when all Airflow components are ready to serve.
         For now, it's simply time-based.
         """
-        return self.port_open(8080) and self.job_running(SchedulerJob) and self.job_running(TriggererJob)
+        return self.port_open(self.web_server_port) and self.job_running(SchedulerJob) and self.job_running(TriggererJob)

Review comment:
       This logic needs to be reviewed and fixed, port_open is called multiple times because of waiting for scheduler job. the socket can be opened after this condition is true - 
   `self.job_running(SchedulerJob) and self.job_running(TriggererJob)`
   to avoid opening and closing socket multiple times.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org