[GitHub] [commons-codec] garydgregory commented on issue #40: CODEC-286 upgrade to commons-lang v3.9

[GitBox <gi...@apache.org>]

garydgregory commented on issue #40: CODEC-286 upgrade to commons-lang v3.9
URL: https://github.com/apache/commons-codec/pull/40#issuecomment-593961445
 
 
   In order to KISS it, perhaps we can:
   
   - Release on more time on Java 7
   - Update to Java 8
   
   Gary
   
   On Tue, Mar 3, 2020 at 7:11 AM Alex Herbert <no...@github.com>
   wrote:
   
   > Having a read of this and you can specify the test source and target
   > separately (see maven compiler plugin
   > <https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html>
   > ):
   >
   >     <maven.compiler.source>1.7</maven.compiler.source>
   >     <maven.compiler.target>1.7</maven.compiler.target>
   >     <maven.compiler.testSource>1.8</maven.compiler.testSource>
   >     <maven.compiler.testTarget>1.8</maven.compiler.testTarget>
   >
   > So you can upgrade the build toolchain and tests to JUnit 5 but still
   > support codec at 1.7. When I made the above changes to the pom this worked
   > fine:
   >
   > @Test
   > public void useLambda() {
   >     IntUnaryOperator f = i -> i * i;
   >     Assert.assertEquals(9, f.applyAsInt(3));
   > }
   >
   > The class files extracted from the jar after running mvn package are
   > version 7 (major version: 51) when inspected using javap -v.
   >
   > Q. Is this going to work for all the other changes you are doing to
   > support a module-info build?
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/commons-codec/pull/40?email_source=notifications&email_token=AAJB6N4SM7JJ3IPB5UAPXELRFTXVZA5CNFSM4K72BQRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENTH3PI#issuecomment-593919421>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAJB6N4GIDOHMMTDZRTHKITRFTXVZANCNFSM4K72BQRA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services