You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/27 06:05:23 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2283: sim: Add a config to test libcxx

yamt commented on a change in pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#discussion_r531398437



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -59,8 +59,8 @@ ifeq ($(CONFIG_CXX_EXCEPTION),)
   ARCHCPUFLAGSXX += -fno-exceptions
 endif
 ARCHPICFLAGS = -fpic
-ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
-ARCHWARNINGSXX = -Wall -Wshadow -Wundef
+ARCHWARNINGS = -Wstrict-prototypes -Wundef
+ARCHWARNINGSXX = -Wundef

Review comment:
       the removal of -Wshadow is explained in the commit message.
   but the removal of -Wall is not. can you explain a bit?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org