[jira] [Comment Edited] (MWAR-433) Maven WAR plugin is deleting files generated by other plugins after upgrading to 3.3.0

["Martin Höller (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWAR-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152517#comment-17152517 ] 

Martin Höller edited comment on MWAR-433 at 7/7/20, 7:43 AM:
-------------------------------------------------------------

Hi!

I also faces this problem with a small demo-application, which ran fine with an older version of the plugin. 

When I was looking into what was the reason for this problem, I came across MWAR-427 and MEAR-278, which are basically the same issues for WAR and EAR plugins. I'm totally unsure if the fix for this issues should have been included at all. I had those problems (MEAR-278) earlier but didn't report a bug because I thought it was a problem on the user-side. When I run maven, change the POM while maven is not active and run maven again, it simply can't know what was previously specified in the POM. And that's why it can't delete reliably, previously included artifacts. 

It would by the same if I compile classes, rename or remove them and compile again. Both classes would end up in the JAR because they were previously copied into the classes-folder. And it would be the same with all other kind of resources. I really think the fixes for MWAR-427 and MEAR-278 are the actual problem and should be reverted. And what [~hboutemy]  is trying to fix is actually a workaround, which just complicates usage of MWAR plugin.

That said,  I'm glad if I could help with testing if the proposed fix is going to be included in the next version. Just let me know where to find the actual sources to test.


was (Author: matinh):
Hi!

 

I also faces this problem with a small demo-application, which ran fine with an older version of the plugin.

 

When I was looking into what was the reason for this problem, I came across MWAR-427 and MEAR-278, which are basically the same issues for WAR and EAR plugins. I'm totally unsure if the fix for this issues should have been included at all. I had those problems (MEAR-278) earlier but didn't report a bug because I thought it was a problem on the user-side. When I run maven, change the POM while maven is not active and run maven again, it simply can't know what was previously specified in the POM. And that's why it can't delete reliably, previously included artifacts.

 

It would by the same if I compile classes, rename or remove them and compile again. Both classes would end up in the JAR because they were previously copied into the classes-folder. And it would be the same with all other kind of resources. I really think the fixes for MWAR-427 and MEAR-278 are the actual problem and should be reverted. And what [~hboutemy]  is trying to fix is actually a workaround, which just complicates usage of MWAR plugin.

 

That said,  I'm glad if I could help with testing if the proposed fix is going to be included in the next version. Just let me know where to find the actual sources to test.

> Maven WAR plugin is deleting files generated by other plugins after upgrading to 3.3.0
> --------------------------------------------------------------------------------------
>
>                 Key: MWAR-433
>                 URL: https://issues.apache.org/jira/browse/MWAR-433
>             Project: Maven WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Kyle Lieber
>            Priority: Critical
>             Fix For: 3.3.1
>
>
> My project generates wsdls using the {{jaxws-maven-plugin}} which puts the generated wsdls in {{${project.build.directory}/${project.build.finalName}/WEB-INF/wsdls}} so that they are packaged up in the war file. Then I have a client jar that copies those wsdls out of the war file using the {{maven-dependency-plugin}} and generates a client from the wsdls using the {{jaxws-maven-plugin}}.
> This all works fine using {{3.2.3}} of the {{maven-war-plugin}}.  However, after upgrading to {{3.3.0}} my project fails to build because the wsdls are no longer preserved.  It seems that they are being deleted by the {{maven-war-plugin}}.
> I created an example project on Github which recreates the problem.  The {{master}} branch is using {{3.2.3}} and the {{maven-war-plugin-3.3.0}} branch is using {{3.3.0}}.  You can find more details in the readme file of the example project:
> https://github.com/klieber/maven-war-plugin-bug
> I also suspect that MWAR-427 is the change that introduced this bug.
> Please let me know if there is anymore information I can provide.  Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)