You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/29 20:04:10 UTC

Review Request 20864: GET request on cluster resource gives psql exception

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20864/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-5623
    https://issues.apache.org/jira/browse/AMBARI-5623


Repository: ambari


Description
-------

Simple patch to do a null/length check on a passed list to the DAO - the fact that it's zero length is causing the SQL error.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 241c1fd 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/20864/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:32.863s
[INFO] Finished at: Tue Apr 29 13:53:06 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 20864: GET request on cluster resource gives psql exception

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20864/#review41738
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On April 29, 2014, 6:04 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20864/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 6:04 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5623
>     https://issues.apache.org/jira/browse/AMBARI-5623
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Simple patch to do a null/length check on a passed list to the DAO - the fact that it's zero length is causing the SQL error.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 241c1fd 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20864/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:32.863s
> [INFO] Finished at: Tue Apr 29 13:53:06 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 20864: GET request on cluster resource gives psql exception

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20864/#review41737
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On April 29, 2014, 6:04 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20864/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 6:04 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5623
>     https://issues.apache.org/jira/browse/AMBARI-5623
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Simple patch to do a null/length check on a passed list to the DAO - the fact that it's zero length is causing the SQL error.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 241c1fd 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20864/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:32.863s
> [INFO] Finished at: Tue Apr 29 13:53:06 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>