[GitHub] [spark] jlpedrosa commented on a change in pull request #24702: [Minor] [Kubernetes] Added retries on the connection to the driver for k8s

[GitBox <gi...@apache.org>]

jlpedrosa commented on a change in pull request #24702: [Minor] [Kubernetes] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r287466256
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
 ##########
 @@ -283,7 +283,12 @@ private[spark] object CoarseGrainedExecutorBackend extends Logging {
         executorConf,
         new SecurityManager(executorConf),
         clientMode = true)
-      val driver = fetcher.setupEndpointRefByURI(arguments.driverUrl)
+
+        val driver = retry(3) {
+          fetcher.setupEndpointRefByURI(arguments.driverUrl)
+        }
 
 Review comment:
   Hi @felixcheung 
   It's the executor used for kubernetes but It canbe called for different resource managers.
   I Labeled it as K8s because it also modifies the docker images used in k8s. Not sure what would be the best component. For instance YarnCoarseGrainedExecutorBackend extends this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org