You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ma...@apache.org on 2022/09/12 12:12:12 UTC
[flink] 02/02: [FLINK-29223][coordination] Address feedback
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 6393f00db8f6ed23245a259d3eb775d5dcc03223
Author: Sergey Nuyanzin <sn...@gmail.com>
AuthorDate: Fri Sep 9 12:36:01 2022 +0200
[FLINK-29223][coordination] Address feedback
---
.../runner/JobDispatcherLeaderProcessFactoryFactory.java | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java
index 2ebc3bce8fc..8d38825bc58 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java
@@ -131,8 +131,12 @@ public class JobDispatcherLeaderProcessFactoryFactory
JobGraph jobGraph, Collection<JobResult> dirtyJobResults) {
final Set<JobID> jobIdsOfFinishedJobs =
dirtyJobResults.stream().map(JobResult::getJobId).collect(Collectors.toSet());
- return jobIdsOfFinishedJobs.contains(jobGraph.getJobID())
- ? Optional.empty()
- : Optional.of(jobGraph);
+ if (jobIdsOfFinishedJobs.contains(jobGraph.getJobID())) {
+ LOG.info(
+ "Skipping recovery of a job with job id {}, because it already reached a globally terminal state",
+ jobGraph.getJobID());
+ return Optional.empty();
+ }
+ return Optional.of(jobGraph);
}
}