You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/06 12:08:20 UTC

[GitHub] smithsz commented on a change in pull request #1605: Feature/user partitioned databases

smithsz commented on a change in pull request #1605: Feature/user partitioned databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r231098046
 
 

 ##########
 File path: src/chttpd/src/chttpd_db.erl
 ##########
 @@ -1453,6 +1525,18 @@ parse_engine_opt(Req) ->
             end
     end.
 
+
+parse_partitioned_opt(Req) ->
+    case chttpd:qs_value(Req, "partitioned") of
 
 Review comment:
   Can you add a `"false"` case here so we can support `PUT /db?partitioned=false` requests?
   Also, it'd be nice to normalise the case using `string:to_lower` (or similar) like we do for other parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services