You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/11 07:16:39 UTC

[GitHub] [apisix-dashboard] FangSen9000 opened a new pull request, #2584: Chore: move yarn to pnpm(try1.5)

FangSen9000 opened a new pull request, #2584:
URL: https://github.com/apache/apisix-dashboard/pull/2584

   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Migrate yarn to pnpm to reduce dependency installation and compilation time.
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2584: Chore: move yarn to pnpm(try1.5)

Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2584:
URL: https://github.com/apache/apisix-dashboard/pull/2584#issuecomment-1213039293

   @bzp2010 At present, I have encountered two problems:
   
   1. After running the command in cypress, the server does not know whether it is running well. This is a strange question. Maybe something is missing. I'm reading the cypress document
   
   2. The rpm and the generation of docker images cannot be carried out because of the lack of pnpm. Why did yarn work before, perhaps because the workflow comes with yarn?
   
   I am looking for commands to install pnpm in the rpm and docker generation files. It is also possible to try to build RPM packages and images myself. I am learning.
   
   I'd like you to take a look. Maybe you with rich experience can see it. Whether there are mistakes in “makefile” and “dockerfile”, and whether there are obvious missing items.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] FangSen9000 closed pull request #2584: Chore: move yarn to pnpm(try1.5)

Posted by GitBox <gi...@apache.org>.
FangSen9000 closed pull request #2584: Chore: move yarn to pnpm(try1.5)
URL: https://github.com/apache/apisix-dashboard/pull/2584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2584: Chore: move yarn to pnpm(try1.5)

Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2584:
URL: https://github.com/apache/apisix-dashboard/pull/2584#issuecomment-1213084793

   To put it simply, there are two GitHub workflows, one is to package and generate rpm, and the other is to package and generate docker image.
   It turned out that I used yarn. When i migrated to pnpm, I saw that neither the dockerfile nor the makefile mentioned yarn. I didn't move these two files. Now there is a problem with these two files, saying that pnpm can't be found
   How can I install a pnpm when generating docker, or install a pnpm when packaging RPM? How can I use Yum? apt？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org