You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/10 15:50:26 UTC

[GitHub] [pulsar] equanz opened a new pull request, #17048: [branch-2.9] Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

equanz opened a new pull request, #17048:
URL: https://github.com/apache/pulsar/pull/17048

   cherry-pick: https://github.com/apache/pulsar/pull/13644
   
   ### Motivation
   
   It seems some test cases like `**/*Test2.java` aren't run on the default test lifecycle.
   This issue is caused by https://github.com/apache/pulsar/pull/10148. I'd like to fix it.
   
   ### Modifications
   
   Originally:
   * Rename test file name to `**/*Test.java`
   * Fix some codes to follow changes
       - https://github.com/apache/pulsar/pull/12687
       - https://github.com/apache/pulsar/pull/11693
       - https://github.com/apache/pulsar/pull/12663
       - https://github.com/apache/pulsar/pull/12749
       - https://github.com/apache/pulsar/pull/11640
   
   Additionally:
   * Fix conflict and keep existing changes
       - https://github.com/apache/pulsar/pull/14657/files#diff-8696b1e2ba4ee355256e31b33ccc4f1cab77f1c6c79f7b4ab508b73d43d8ad55L477-R471
   * Revert some codes because the change is not cherry-picked to `branch-2.9` yet
       - https://github.com/apache/pulsar/pull/12687
   * Cherry-picked additional changes about test code because existing cherry-pick commit is imcomplete
       - existing cherry-pick commit: https://github.com/apache/pulsar/commit/4f65f65c6fe6f7e97e83a13d038c6dbf28c3f8c6
       - original commit: https://github.com/apache/pulsar/commit/ecd275dc21f33483a649e5b872990771257b1d45
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   - [x] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on pull request #17048: [branch-2.9] Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

Posted by GitBox <gi...@apache.org>.
equanz commented on PR #17048:
URL: https://github.com/apache/pulsar/pull/17048#issuecomment-1211520156

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao merged pull request #17048: [branch-2.9] Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

Posted by GitBox <gi...@apache.org>.
mattisonchao merged PR #17048:
URL: https://github.com/apache/pulsar/pull/17048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org