You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/20 12:52:25 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #4261: improve error messages while downcasting `UInt32Array`, `UInt64Array` and `BooleanArray`

liukun4515 commented on PR #4261:
URL: https://github.com/apache/arrow-datafusion/pull/4261#issuecomment-1321125625

   > I think this is a good improvement that we can merge and then work on unifying with the downcast macro later. If people feel strongly about the downcast macro I can do that too
   > If we are worried about code duplication, perhaps we can use downcast_value to implement the as_boolean_array, type methods
   @retikulum @alamb 
   
   It's a good idea to implement `as_xxx_array` using the `downcast_value`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org