[GitHub] [incubator-kvrocks] git-hulk commented on issue #1484: Don't allow to slaveof itself or its replica

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on issue #1484:
URL: https://github.com/apache/incubator-kvrocks/issues/1484#issuecomment-1578054708

   @jihuayu Firstly, we don't promise it can recognize all conditions since the traffic device mapping is complex. What we can do is try our best to avoid this condition, so I think the below checks are enough:
   
   - if Kvrocks is listening on address 0.0.0.0, we parse the IP addresses from device and compare the master host and port
   - if Kvrocks is listening on the exact IP address, just compare the IP and Port directly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org