You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/31 16:30:42 UTC

[GitHub] [couchdb] sklassen opened a new pull request #2738: Replace VM_ARGS with ARGS_FILE which is borrowed from couchdb startup

sklassen opened a new pull request #2738: Replace VM_ARGS with ARGS_FILE which is borrowed from couchdb startup
URL: https://github.com/apache/couchdb/pull/2738
 
 
   Replaced the environment VM_ARGS with ARGS_FILE, which is the same name and set the same manner as the couchdb script; 
   
   The new script also parses name from the same file.
   
   ## Overview
   
   The current remsh script required you specify the name and cookie if they differ from the system default. The new script synchronizes the setting of ARGS_FILE with that environment in the couchdb startup script. This now also, like the couchdb startup script, respects any COUCHDB_ARGS_FILE override.
   
   ## Testing recommendations
   
   I changed the COUCHDB_ARGS_FILE environment variable and reran rmsh it and saw that it picked up non-default name and cookie.
   
   ## Related Issues or Pull Requests
   
   This answers (the linux) part of #2176
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [X] Changes are covered by tests
   - [X] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services