You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2023/10/19 12:15:30 UTC

[maven-jenkins-lib] branch master updated: Remove redundant cleanWs

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git


The following commit(s) were added to refs/heads/master by this push:
     new 100e795  Remove redundant cleanWs
100e795 is described below

commit 100e795f8108b25b77e65844d57a1e49658512bf
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Thu Oct 19 14:15:17 2023 +0200

    Remove redundant cleanWs
    
    cleanWs is called in finally block
    if is executed early, tests reports can be missed on failed build
---
 vars/asfMavenTlpPlgnBuild.groovy | 2 --
 vars/asfMavenTlpStdBuild.groovy  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/vars/asfMavenTlpPlgnBuild.groovy b/vars/asfMavenTlpPlgnBuild.groovy
index e4452db..e8e8efa 100644
--- a/vars/asfMavenTlpPlgnBuild.groovy
+++ b/vars/asfMavenTlpPlgnBuild.groovy
@@ -217,8 +217,6 @@ def doCreateTask( os, jdk, maven, tasks, first, plan, taskContext )
             }
           } catch (Throwable e) {
             archiveDirs(taskContext.archives, stageDir)
-            // First step to keep the workspace clean and safe disk space
-            cleanWs()
             if (!taskContext.failFast) {
               throw e
             } else if (taskContext.failingFast == null) {
diff --git a/vars/asfMavenTlpStdBuild.groovy b/vars/asfMavenTlpStdBuild.groovy
index bf3e201..6abb1c6 100644
--- a/vars/asfMavenTlpStdBuild.groovy
+++ b/vars/asfMavenTlpStdBuild.groovy
@@ -132,8 +132,6 @@ def call(Map params = [:]) {
                     }
                   } catch (Throwable e) {
                     echo "[FAILURE-004] ${e}"
-                    // First step to keep the workspace clean and safe disk space
-                    cleanWs()
                     if (!failFast) {
                       throw e
                     } else if (failingFast == null) {