You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/04/13 06:49:29 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl
github-actions[bot] commented on code in PR #18627:
URL: https://github.com/apache/doris/pull/18627#discussion_r1165077989
##########
be/src/vec/data_types/serde/data_type_array_serde.h:
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeArraySerDe : public DataTypeSerDe {
+public:
+ DataTypeArraySerDe(const DataTypeSerDeSPtr& _nested_serde) : nested_serde(_nested_serde) {}
+
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const override;
```
##########
be/src/vec/data_types/serde/data_type_decimal_serde.h:
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+#include "vec/columns/column_decimal.h"
+
+namespace doris {
+
+namespace vectorized {
+
+template <typename T>
+class DataTypeDecimalSerDe : public DataTypeSerDe {
+ static_assert(IsDecimalNumber<T>);
+
+public:
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const override;
```
##########
be/src/vec/data_types/serde/data_type_map_serde.h:
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeMapSerDe : public DataTypeSerDe {
+public:
+ DataTypeMapSerDe(const DataTypeSerDeSPtr& _key_serde, const DataTypeSerDeSPtr& _value_serde)
+ : key_serde(_key_serde), value_serde(_value_serde) {}
+
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status read_column_from_pb(IColumn& column, const PValues& arg) const override;
```
##########
be/src/vec/data_types/serde/data_type_map_serde.h:
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeMapSerDe : public DataTypeSerDe {
+public:
+ DataTypeMapSerDe(const DataTypeSerDeSPtr& _key_serde, const DataTypeSerDeSPtr& _value_serde)
+ : key_serde(_key_serde), value_serde(_value_serde) {}
+
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const override;
```
##########
be/src/vec/data_types/serde/data_type_array_serde.h:
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeArraySerDe : public DataTypeSerDe {
+public:
+ DataTypeArraySerDe(const DataTypeSerDeSPtr& _nested_serde) : nested_serde(_nested_serde) {}
+
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status read_column_from_pb(IColumn& column, const PValues& arg) const override;
```
##########
be/src/vec/data_types/serde/data_type_struct_serde.h:
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeStructSerDe : public DataTypeSerDe {
+public:
+ DataTypeStructSerDe(const DataTypeSerDeSPtrs& _elemSerDeSPtrs)
+ : elemSerDeSPtrs(_elemSerDeSPtrs) {}
+
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status read_column_from_pb(IColumn& column, const PValues& arg) const override;
```
##########
be/src/vec/data_types/serde/data_type_decimal_serde.h:
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+#include "vec/columns/column_decimal.h"
+
+namespace doris {
+
+namespace vectorized {
+
+template <typename T>
+class DataTypeDecimalSerDe : public DataTypeSerDe {
+ static_assert(IsDecimalNumber<T>);
+
+public:
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status read_column_from_pb(IColumn& column, const PValues& arg) const override;
```
##########
be/src/vec/data_types/serde/data_type_object_serde.h:
##########
@@ -0,0 +1,29 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeObjectSerDe : public DataTypeSerDe {
+public:
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status read_column_from_pb(IColumn& column, const PValues& arg) const override;
```
##########
be/src/vec/data_types/serde/data_type_object_serde.h:
##########
@@ -0,0 +1,29 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeObjectSerDe : public DataTypeSerDe {
+public:
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const override;
```
##########
be/src/vec/data_types/serde/data_type_struct_serde.h:
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "data_type_serde.h"
+namespace doris {
+
+namespace vectorized {
+
+class DataTypeStructSerDe : public DataTypeSerDe {
+public:
+ DataTypeStructSerDe(const DataTypeSerDeSPtrs& _elemSerDeSPtrs)
+ : elemSerDeSPtrs(_elemSerDeSPtrs) {}
+
+ Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org