You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by bo...@apache.org on 2023/03/10 03:05:43 UTC
[kyuubi] branch master updated: [KYUUBI #4489] [REST] Fix missing `org.apache.commons.logging` by including `jcl-over-slf4j` dependency in REST client
This is an automated email from the ASF dual-hosted git repository.
bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 61a609604 [KYUUBI #4489] [REST] Fix missing `org.apache.commons.logging` by including `jcl-over-slf4j` dependency in REST client
61a609604 is described below
commit 61a6096043821a2da61363e173090cabfecb58a1
Author: liangbowen <li...@gf.com.cn>
AuthorDate: Fri Mar 10 11:05:32 2023 +0800
[KYUUBI #4489] [REST] Fix missing `org.apache.commons.logging` by including `jcl-over-slf4j` dependency in REST client
### _Why are the changes needed?_
- To fix missing package `org.apache.commons.logging` used by `org.apache.httpcomponents:httpclient`in `kyuubi-rest-client`
![image](https://user-images.githubusercontent.com/1935105/224203940-246db855-0ffa-469e-8a67-58143e6e99e3.png)
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #4489 from bowenliang123/httpclient-commonlogging.
Closes #4489
ccaff9b62 [liangbowen] Include `jcl-over-slf4j` dependency
740e56158 [liangbowen] Revert "skip excluding commons-logging in rest-client"
4d9ad5dcf [liangbowen] skip excluding commons-logging in rest-client
Authored-by: liangbowen <li...@gf.com.cn>
Signed-off-by: liangbowen <li...@gf.com.cn>
---
kyuubi-rest-client/pom.xml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kyuubi-rest-client/pom.xml b/kyuubi-rest-client/pom.xml
index 6ba88e8dc..a9ceb9bb3 100644
--- a/kyuubi-rest-client/pom.xml
+++ b/kyuubi-rest-client/pom.xml
@@ -82,6 +82,11 @@
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>jcl-over-slf4j</artifactId>
+ </dependency>
+
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>