[GitHub] [commons-lang] garydgregory commented on a diff in pull request #926: Fix links in Javadoc and documentations

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #926:
URL: https://github.com/apache/commons-lang/pull/926#discussion_r935954134


##########
src/site/xdoc/building.xml:
##########
@@ -24,8 +24,8 @@ limitations under the License.
 <!-- ================================================== -->
 <section name="Overview">
 <p>
-  Commons Lang uses <a href="http://maven.apache.org">Maven</a> or
-  <a href="http://ant.apache.org">Ant</a> as a build system.
+  Commons Lang uses <a href="https://maven.apache.org">Maven</a> or
+  <a href="https://ant.apache.org">Ant</a> as a build system.

Review Comment:
   -1: We do not use Ant, only Maven.



##########
src/test/java/org/apache/commons/lang3/StringUtilsContainsTest.java:
##########
@@ -105,7 +105,7 @@ public void testContainsAny_StringCharArray() {
     }
 
     /**
-     * See http://www.oracle.com/technetwork/articles/javase/supplementary-142654.html
+     * See https://www.oracle.com/technetwork/articles/javase/supplementary-142654.html

Review Comment:
   There is no such URL, it redirects to https://www.oracle.com/technical-resources/articles/javase/supplementary.html
   



##########
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java:
##########
@@ -37,7 +37,7 @@
  *
  * <p>
  * This class enables a good {@code hashCode} method to be built for any class. It follows the rules laid out in
- * the book <a href="http://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a
+ * the book <a href="https://www.oracle.com/technetwork/java/effectivejava-136174.html">Effective Java</a> by Joshua Bloch. Writing a

Review Comment:
   There is no such page, it redirects to https://www.oracle.com/java/technologies/effectivejava.html



##########
src/main/java/org/apache/commons/lang3/CharEncoding.java:
##########
@@ -23,14 +23,14 @@
 /**
  * <p>Character encoding names required of every implementation of the Java platform.</p>
  *
- * <p>According to <a href="http://docs.oracle.com/javase/1.3/docs/api/java/lang/package-summary.html#charenc">JRE character
+ * <p>According to <a href="https://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">JRE character

Review Comment:
   Javadoc references should be to Java **8** since this is the Java level this component requires.
   



##########
src/main/java/org/apache/commons/lang3/CharUtils.java:
##########
@@ -46,7 +46,7 @@ public class CharUtils {
     /**
      * Carriage return character CR ('\r', Unicode 000d).
      *
-     * @see <a href="http://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.6">JLF: Escape Sequences
+     * @see <a href="https://docs.oracle.com/javase/specs/jls/se7/html/jls-3.html#jls-3.10.6">JLF: Escape Sequences

Review Comment:
   Should point to Java 8, not 7.



##########
src/main/java/org/apache/commons/lang3/SystemUtils.java:
##########
@@ -1084,7 +1084,7 @@ public class SystemUtils {
     // -----------------------------------------------------------------------
     // These MUST be declared after those above as they depend on the
     // values being set up
-    // OS names from http://www.vamphq.com/os.html
+    // OS names from http://lopica.sourceforge.net/os.html

Review Comment:
   Why? Let's not replace one (insecure) URL with another: "The connection to lopica.sourceforge.net is not secure" Also the comment is no longer true since we did not, in fact, get the data from lopica.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org