You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/03 04:22:15 UTC
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new issue #1691:
Refactor alert template
Technoboy- opened a new issue #1691: Refactor alert template
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1691
Background
Now, we use FreeMarker to load alert template, and only this simple function.
Suggestion
Removing FreeMarker, use a template interface , and default implementation is concat string. Anyone who want to extend , just implement the interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1691:
Refactor alert template
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #1691: Refactor alert template
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1691#issuecomment-570459249
+1，does not affect existing features
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #1691:
Refactor alert template
Posted by GitBox <gi...@apache.org>.
Yeleights commented on issue #1691: Refactor alert template
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1691#issuecomment-570460216
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- closed issue #1691:
Refactor alert template
Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #1691: Refactor alert template
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei edited a comment on issue
#1691: Refactor alert template
Posted by GitBox <gi...@apache.org>.
qiaozhanwei edited a comment on issue #1691: Refactor alert template
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1691#issuecomment-570459249
+1，does not affect existing functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] clay4444 commented on issue #1691:
Refactor alert template
Posted by GitBox <gi...@apache.org>.
clay4444 commented on issue #1691: Refactor alert template
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1691#issuecomment-570462548
+1，i will implement this，
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services