You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/03 13:36:00 UTC
[jira] [Work logged] (HIVE-24288) Files created by CompileProcessor
have incorrect permissions
[ https://issues.apache.org/jira/browse/HIVE-24288?focusedWorklogId=506693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506693 ]
ASF GitHub Bot logged work on HIVE-24288:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/20 13:35
Start Date: 03/Nov/20 13:35
Worklog Time Spent: 10m
Work Description: yongzhi commented on a change in pull request #1590:
URL: https://github.com/apache/hive/pull/1590#discussion_r516202877
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -254,6 +276,9 @@ CommandProcessorResponse compile(SessionState ss) throws CommandProcessorExcepti
if (ss != null){
ss.add_resource(ResourceType.JAR, testArchive.getAbsolutePath());
+ try {
+ testArchive.deleteOnExit();
Review comment:
Then delete at exit should be fine.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -241,14 +254,26 @@ CommandProcessorResponse compile(SessionState ss) throws CommandProcessorExcepti
out.closeArchiveEntry();
}
out.finish();
+ setPosixFilePermissions(testArchive, lockout, false);
Review comment:
What's the purpose of set the permission here? Could it happen before the write operations above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 506693)
Time Spent: 1h 10m (was: 1h)
> Files created by CompileProcessor have incorrect permissions
> ------------------------------------------------------------
>
> Key: HIVE-24288
> URL: https://issues.apache.org/jira/browse/HIVE-24288
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.1.0
> Reporter: Naveen Gangam
> Assignee: Naveen Gangam
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Compile processor generates some temporary files as part of processing. These need to be cleaned up on exit from CLI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)