[GitHub] mistercrunch closed pull request #5093: Fix python2 str() in visualization

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5093: Fix python2 str() in visualization
URL: https://github.com/apache/incubator-superset/pull/5093
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/viz.py b/superset/viz.py
index db09fb29f8..1086af89fd 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1089,11 +1089,11 @@ def to_series(self, df, classed='', title_suffix=''):
             if df[name].dtype.kind not in 'biufc':
                 continue
             if isinstance(name, list):
-                series_title = [str(title) for title in name]
+                series_title = [text_type(title) for title in name]
             elif isinstance(name, tuple):
-                series_title = tuple(str(title) for title in name)
+                series_title = tuple(text_type(title) for title in name)
             else:
-                series_title = str(name)
+                series_title = text_type(name)
             if (
                     isinstance(series_title, (list, tuple)) and
                     len(series_title) > 1 and


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org