You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2023/10/17 13:22:44 UTC

Re: [PR] MINOR: [R] Avoid stray output from expr when checking for 10.13 [arrow]

jonkeane commented on code in PR #38303:
URL: https://github.com/apache/arrow/pull/38303#discussion_r1362100419


##########
r/configure:
##########
@@ -264,7 +264,7 @@ set_pkg_vars () {
     PKG_CFLAGS="$PKG_CFLAGS $ARROW_R_CXXFLAGS"
   fi
 
-  if [ "$UNAME" = "Darwin" ] && expr $(sw_vers -productVersion) : '10\.13'; then
+  if [ "$UNAME" = "Darwin" ] && expr $(sw_vers -productVersion) : '10\.13' >/dev/null 2>&1; then

Review Comment:
   Could you add a comment here about why expr + why `>/dev/null 2>&1` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org