You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/12/10 23:50:32 UTC

Re: Review Request 71660: SSL Wrapper: Stubbed out a SSL socket class.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71660/
-----------------------------------------------------------

(Updated Dec. 10, 2019, 3:50 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.


Changes
-------

Renamed the new class from SSLSocketWrapper to OpenSSLSocketImpl.
The file was renamed too.


Bugs: MESOS-10009
    https://issues.apache.org/jira/browse/MESOS-10009


Repository: mesos


Description
-------

This creates some new files implementing the SocketImpl class,
in preparation for implementing generic SSL sockets.

The new class is used whenever SSL is enabled, but Libevent is not.


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 641251af5631e9b3928dfb282cdbc266ba76572e 
  3rdparty/libprocess/src/CMakeLists.txt 40c8ef935104bab4ea2f8b2b5919450b55165f60 
  3rdparty/libprocess/src/openssl.cpp 8aab5acfb4bf3aa94625eaa7157714eca98940f7 
  3rdparty/libprocess/src/socket.cpp 606a1c46e50936251c29af4b996007c480b2a135 
  3rdparty/libprocess/src/ssl/openssl_socket.hpp PRE-CREATION 
  3rdparty/libprocess/src/ssl/openssl_socket.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71660/diff/4/

Changes: https://reviews.apache.org/r/71660/diff/3-4/


Testing
-------

cmake .. -ENABLE_SSL=1   # No Libevent here!


Thanks,

Joseph Wu