You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2007/05/30 00:52:15 UTC

[jira] Created: (WICKET-598) Support jetty continuations in wicket

Support jetty continuations in wicket
-------------------------------------

                 Key: WICKET-598
                 URL: https://issues.apache.org/jira/browse/WICKET-598
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
            Reporter: Peter Ertl


Using jetty continuations does not work on wicket.

info about jetty continuations:
http://docs.codehaus.org/display/JETTY/Continuations

Calling jetty's

   continuation.suspend(timeout);

will fail as it raises an RetryRequest exception that is caught by wicket.

It should be let through instead so jetty server will be able to handle it.

I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket :-)

I will attach a patch that fixes the issue...



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-598) Support jetty continuations in wicket

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius reassigned WICKET-598:
--------------------------------------

    Assignee: Eelco Hillenius

> Support jetty continuations in wicket
> -------------------------------------
>
>                 Key: WICKET-598
>                 URL: https://issues.apache.org/jira/browse/WICKET-598
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Eelco Hillenius
>         Attachments: jetty-continuations.patch
>
>
> Using jetty continuations does not work on wicket.
> info about jetty continuations:
> http://docs.codehaus.org/display/JETTY/Continuations
> Calling jetty's
>    continuation.suspend(timeout);
> will fail as it raises an RetryRequest exception that is caught by wicket.
> It should be let through instead so jetty server will be able to handle it.
> I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket :-)
> I will attach a patch that fixes the issue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-598) Support jetty continuations in wicket

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-598:
------------------------------

    Attachment: jetty-continuations.patch

> Support jetty continuations in wicket
> -------------------------------------
>
>                 Key: WICKET-598
>                 URL: https://issues.apache.org/jira/browse/WICKET-598
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>         Attachments: jetty-continuations.patch
>
>
> Using jetty continuations does not work on wicket.
> info about jetty continuations:
> http://docs.codehaus.org/display/JETTY/Continuations
> Calling jetty's
>    continuation.suspend(timeout);
> will fail as it raises an RetryRequest exception that is caught by wicket.
> It should be let through instead so jetty server will be able to handle it.
> I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket :-)
> I will attach a patch that fixes the issue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-598) Support jetty continuations in wicket

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-598:
--------------------------------

    Fix Version/s: 1.4.0-alpha

> Support jetty continuations in wicket
> -------------------------------------
>
>                 Key: WICKET-598
>                 URL: https://issues.apache.org/jira/browse/WICKET-598
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Eelco Hillenius
>             Fix For: 1.4.0-alpha
>
>         Attachments: jetty-continuations.patch
>
>
> Using jetty continuations does not work on wicket.
> info about jetty continuations:
> http://docs.codehaus.org/display/JETTY/Continuations
> Calling jetty's
>    continuation.suspend(timeout);
> will fail as it raises an RetryRequest exception that is caught by wicket.
> It should be let through instead so jetty server will be able to handle it.
> I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket :-)
> I will attach a patch that fixes the issue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-598) Support jetty continuations in wicket

Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500035 ] 

Jonathan Locke commented on WICKET-598:
---------------------------------------

This is an RFE.  We're feature frozen.  Shouldn't we kick this to next version?

> Support jetty continuations in wicket
> -------------------------------------
>
>                 Key: WICKET-598
>                 URL: https://issues.apache.org/jira/browse/WICKET-598
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Eelco Hillenius
>         Attachments: jetty-continuations.patch
>
>
> Using jetty continuations does not work on wicket.
> info about jetty continuations:
> http://docs.codehaus.org/display/JETTY/Continuations
> Calling jetty's
>    continuation.suspend(timeout);
> will fail as it raises an RetryRequest exception that is caught by wicket.
> It should be let through instead so jetty server will be able to handle it.
> I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket :-)
> I will attach a patch that fixes the issue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-598) Support jetty continuations in wicket

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500034 ] 

Eelco Hillenius commented on WICKET-598:
----------------------------------------

I'm really not sure how to handle this in the best way. One thing you can see from your own patch, is that by providing your own RequestCycle (override logRuntimeException) and a custom request cycle processor (extend WebRequestCycleProcessor and override respond(RuntimeException, RequestCycle)).

> Support jetty continuations in wicket
> -------------------------------------
>
>                 Key: WICKET-598
>                 URL: https://issues.apache.org/jira/browse/WICKET-598
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Eelco Hillenius
>         Attachments: jetty-continuations.patch
>
>
> Using jetty continuations does not work on wicket.
> info about jetty continuations:
> http://docs.codehaus.org/display/JETTY/Continuations
> Calling jetty's
>    continuation.suspend(timeout);
> will fail as it raises an RetryRequest exception that is caught by wicket.
> It should be let through instead so jetty server will be able to handle it.
> I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket :-)
> I will attach a patch that fixes the issue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.