You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2008/04/22 00:59:21 UTC
[jira] Issue Comment Edited: (DERBY-3623) Convert deadlockMode.java
to JUnit
[ https://issues.apache.org/jira/browse/DERBY-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591082#action_12591082 ]
kmarsden edited comment on DERBY-3623 at 4/21/08 3:57 PM:
----------------------------------------------------------------
Need to remove master/deadlockMode.out.
-Table setup should be in decorateSQL method instead of setup. Then cleanup of the table will be automatic. See BatchUpdateTest for an example.
-There is no need to check success of each insert. It will just throw an exception if there is a problem.
When I run the test it passes but I see these exceptions in the console: I think the code:
} catch (Exception e) {
checkThreadsDone();
assertNull(
"FAIL - Exception thrown",
e);
}
is not quite right. We normally want to throw the exception but since this is a multithreaded test I see that won't quite work. Anyway I am investigating.
testThreadsUpdatingTable Exception in thread "Thread-26" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
...
was (Author: kmarsden):
Need to remove master/deadlockMode.out.
-Table setup should be in decorateSQL method instead of setup. Then cleanup of the table will be automatic. See BatchUpdateTest for an example.
-There is no need to check success of each insert. It will just throw an exception if there is a problem.
When I run the test it passes but I see these exceptions in the console: I think the code:
} catch (Exception e) {
checkThreadsDone();
assertNull(
"FAIL - Exception thrown",
e);
}
is not quite right. We normally want to throw the exception but since this is a multithreaded test I see that won't quite work. Anyway I am investigating.
testThreadsUpdatingTable Exception in thread "Thread-26" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-37" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-44" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-33" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-31" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-43" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-40" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-29" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-32" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-38" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-30" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-28" junit.framework.AssertionFailedError: FAIL - Exception thrown
Exception in thread "Thread-34" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.fail(Assert.java:47)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-36" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-42" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-41" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
Exception in thread "Thread-35" at java.lang.Thread.run(Thread.java:803)
junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-25" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-39" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
Exception in thread "Thread-27" junit.framework.AssertionFailedError: FAIL - Exception thrown
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:233)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.threadWorker(DeadlockModeTest.java:201)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest.access$000(DeadlockModeTest.java:46)
at org.apache.derbyTesting.functionTests.tests.lang.DeadlockModeTest$1.run(DeadlockModeTest.java:133)
at java.lang.Thread.run(Thread.java:803)
used 110 ms
Time: 8
OK (2 tests)
+ set +x
[C:/test]
> Convert deadlockMode.java to JUnit
> ----------------------------------
>
> Key: DERBY-3623
> URL: https://issues.apache.org/jira/browse/DERBY-3623
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby3623.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.