You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/11 16:14:38 UTC
[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13519: [FLINK-18850][Table SQL / Runtime]Add late records dropped metric for row time over windows
zhuxiaoshang commented on a change in pull request #13519:
URL: https://github.com/apache/flink/pull/13519#discussion_r502935531
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/over/RowTimeRangeBoundedPrecedingFunction.java
##########
@@ -86,12 +90,25 @@
private transient AggsHandleFunction function;
+ // ------------------------------------------------------------------------
+ // Metrics
+ // ------------------------------------------------------------------------
+ protected static final String LATE_ELEMENTS_DROPPED_METRIC_NAME = "numLateRecordsDropped";
+ protected static final String LATE_ELEMENTS_DROPPED_RATE_METRIC_NAME = "lateRecordsDroppedRate";
Review comment:
I have saw the discussions in FLINK-15431,i'll follow it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org