[GitHub] [spark] LuciferYang commented on a change in pull request #34425: [SPARK-37159][SQL][TESTS] Change HiveExternalCatalogVersionsSuite to be able to test with Java 17

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #34425:
URL: https://github.com/apache/spark/pull/34425#discussion_r739006444



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -263,6 +267,8 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
     versions
       .filter(v => v.startsWith("3") || !TestUtils.isPythonVersionAtLeast38())
       .filter(v => v.startsWith("3") || !SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
+      .filter(v => !((v.startsWith("3.0") || v.startsWith("3.1")) &&
+        SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_17)))

Review comment:
       > We don't support Java 17 on 3.0 and 3.1. I believe we can spin off this from this PR.
   
   In addition, I didn't find that Spark 3.2.0 supports JDK 17 in [spark-release-3-2-0](http://spark.apache.org/releases/spark-release-3-2-0.html), so do we really need to test 3.2.0? Some pr for JDK 17 are not merge into 3.2, such as SPARK-37013




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org