You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/03/10 02:38:38 UTC
Review Request 31877: Create mock YARN theme for UI development
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31877/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-9991
https://issues.apache.org/jira/browse/AMBARI-9991
Repository: ambari
Description
-------
Create mock YARN theme for UI development
Diffs
-----
ambari-web/app/templates/main/service/info/configs/yarn_theme.json PRE-CREATION
Diff: https://reviews.apache.org/r/31877/diff/
Testing
-------
Manually tested on live cluster. No unit test applicable.
Thanks,
Richard Zang
Re: Review Request 31877: Create mock YARN theme for UI development
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31877/#review75845
-----------------------------------------------------------
ambari-web/app/templates/main/service/info/configs/yarn_theme.json
<https://reviews.apache.org/r/31877/#comment123165>
'subsection-id' should be changed to 'subsection-name'.
- Srimanth Gunturi
On March 10, 2015, 1:38 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31877/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 1:38 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-9991
> https://issues.apache.org/jira/browse/AMBARI-9991
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create mock YARN theme for UI development
>
>
> Diffs
> -----
>
> ambari-web/app/templates/main/service/info/configs/yarn_theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31877/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster. No unit test applicable.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 31877: Create mock YARN theme for UI development
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31877/#review75844
-----------------------------------------------------------
ambari-web/app/templates/main/service/info/configs/yarn_theme.json
<https://reviews.apache.org/r/31877/#comment123162>
The structure now is:
- Theme
-- configuration
--- layouts
--- placement
--- widgets
ambari-web/app/templates/main/service/info/configs/yarn_theme.json
<https://reviews.apache.org/r/31877/#comment123161>
We need an extra field called "display-name" also to allow for internationalization later. "display-name" and "name" could be provided for tabs and sections and sub-sections.
ambari-web/app/templates/main/service/info/configs/yarn_theme.json
<https://reviews.apache.org/r/31877/#comment123163>
We currently have only 1 placement, so better to revert this back to 'placement'.
ambari-web/app/templates/main/service/info/configs/yarn_theme.json
<https://reviews.apache.org/r/31877/#comment123164>
subsection-id not required inside widgets.
- Srimanth Gunturi
On March 10, 2015, 1:38 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31877/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 1:38 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-9991
> https://issues.apache.org/jira/browse/AMBARI-9991
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create mock YARN theme for UI development
>
>
> Diffs
> -----
>
> ambari-web/app/templates/main/service/info/configs/yarn_theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31877/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster. No unit test applicable.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 31877: Create mock YARN theme for UI development
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31877/#review75993
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On March 10, 2015, 8:02 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31877/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 8:02 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-9991
> https://issues.apache.org/jira/browse/AMBARI-9991
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create mock YARN theme for UI development
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31877/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster. No unit test applicable.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 31877: Create mock YARN theme for UI development
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31877/
-----------------------------------------------------------
(Updated March 10, 2015, 8:02 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
Adjust unit name, file name and location
Bugs: AMBARI-9991
https://issues.apache.org/jira/browse/AMBARI-9991
Repository: ambari
Description
-------
Create mock YARN theme for UI development
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/theme.json PRE-CREATION
Diff: https://reviews.apache.org/r/31877/diff/
Testing
-------
Manually tested on live cluster. No unit test applicable.
Thanks,
Richard Zang
Re: Review Request 31877: Create mock YARN theme for UI development
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31877/
-----------------------------------------------------------
(Updated March 10, 2015, 7:08 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
Adjust mock according to design changes
Bugs: AMBARI-9991
https://issues.apache.org/jira/browse/AMBARI-9991
Repository: ambari
Description
-------
Create mock YARN theme for UI development
Diffs (updated)
-----
ambari-web/app/assets/data/services/configs/yarn_theme.json PRE-CREATION
Diff: https://reviews.apache.org/r/31877/diff/
Testing
-------
Manually tested on live cluster. No unit test applicable.
Thanks,
Richard Zang