[GitHub] [airflow] ferruzzi commented on issue #19641: EKSCreateNodegroupOperator - missing kwargs

[GitBox <gi...@apache.org>]

ferruzzi commented on issue #19641:
URL: https://github.com/apache/airflow/issues/19641#issuecomment-971874324


   @andormarkus (and anyone else who wants to weigh in, of course) - It looks like the way Glue solved this was by adding a dict called "create_job_kwargs" which gets unpacked in the boto call.  That would keep the code concise and allow for future boto changes easily, but makes that extra step of packing it into a dict for the end user.  The alternative is defining every potential parameter that boto accepts, and having to keep that up to date.  So this dict is cleaner in the code and a bit more future-proof perhaps, but an extra step for the user.  How do you feel about this?
   
   Example usage should look something like:
   
   ```
   create_nodegroup = EKSCreateNodegroupOperator(
       task_id='create_eks_nodegroup',
       cluster_name=cluster_name,
       nodegroup_name=node_group_name,
       nodegroup_subnets=get_subnets(),
       nodegroup_role_arn=get_node_role(),
       create_nodegroup_kwargs={
           amiType = "BOTTLEROCKET_x86_64",
           instanceTypes = "t3.large",
           capacityType = "ON_DEMAND"
       }
   )
   ```
   
   I'd add the same workaround for create_cluster and create_fargate_profile while I'm at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org