You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:27:13 UTC

[GitHub] [superset] aspedrosa commented on issue #8501: Still fetching fav-star data when no user is logged in

aspedrosa commented on issue #8501:
URL: https://github.com/apache/superset/issues/8501#issuecomment-863471454


   Found the source of the new bug
   The code shows this [line](https://github.com/apache/superset/blob/1.2.0rc2/superset-frontend/src/dashboard/components/Header/index.jsx#L405). The variable `dashboardInfo.userId` is a valid string so react renders the FaveStar component.
   
   ![bug_favstar](https://user-images.githubusercontent.com/23409890/122453156-f1e60500-cfa1-11eb-9a9e-6d152985fcd2.png)
   
   Don't know who to tag, so I will tag the ones that reviewed the PR that fixed the previous version of this bug @etr2460 @nytai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org