You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/09/20 16:23:25 UTC
[PR] CAMEL-24850: the validator says what to write for pollEnrich/enrich with a uri, a steps item inside steps, and EIPs directly under step [camel]
davsclaus opened a new pull request, #26633:
URL: https://github.com/apache/camel/pull/26633
## Description
Three shapes from the round-2 benchmark (series l2, 155 attempts of a local model on the camel-jbang-examples ladder) that the schema validator rejected with a message that did not say what to write, so a model or a person needs another round or two to get past them. Three rows in `SchemaHints.PROPERTY`, placed before the generic did-you-mean row:
- **`pollEnrich: {uri: ...}` / `enrich: {resourceUri: ...}`** (3 attempts, 3 examples; all three ran the file anyway and died at startup): the endpoint is an expression, and the message now says so with the value echoed: `the endpoint of pollEnrich is an expression: write pollEnrich: {expression: {constant: {expression: "file:./order.json"}}}`.
- **`- steps:` as a grouping item inside a steps list, or `steps:` on an EIP without a pipeline** (7 attempts): `steps: is the list of a route or of an EIP that owns a pipeline (filter, split, choice, step); an EIP is an item of that list, not a group inside it: move the items up one level, or use step: {id: ..., steps: [...]} for a named group`. This row also removes the `did you mean 'step'?` suggestion for the case, which led the model to the next shape.
- **EIP names directly under `step`**: `step is the Step EIP, a named group: its EIPs go in its steps: list (step: {id: ..., steps: [- setHeader: ...]})`. A replace row with a fixed text, so the errors for each EIP under one `step` collapse into one line through the existing dedup instead of one "property 'x' is not defined" per EIP.
The two existing steps rows (`steps` under `route`, an EIP name misplaced under a pipeline owner) keep their messages; the new one matches what they do not.
## Tests
`YamlValidatorPropertyHintTest`: one test per shape, run in classic and canonical mode; the step case asserts exactly one message, the steps case asserts no did-you-mean. All 129 validator tests green.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24850: the validator says what to write for pollEnrich/enrich with a uri, a steps item inside steps, and EIPs directly under step [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26633:
URL: https://github.com/apache/camel/pull/26633#issuecomment-5751056765
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24850: the validator says what to write for pollEnrich/enrich with a uri, a steps item inside steps, and EIPs directly under step [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26633:
URL: https://github.com/apache/camel/pull/26633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24850: the validator says what to write for pollEnrich/enrich with a uri, a steps item inside steps, and EIPs directly under step [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26633:
URL: https://github.com/apache/camel/pull/26633#issuecomment-5751225860
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-yaml-dsl/camel-yaml-dsl-validator`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 8 of 692 tested, 9 compile-only — current: 8 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **17 affected modules** (current approach: 8).
**Skip-tests mode would test 8 modules** (1 direct + 7 downstream), **skip tests for 9** (generated code, meta-modules)
<details><summary>:warning: Modules only in Scalpel (9)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
<details><summary>Modules Scalpel would test (8)</summary>
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
- `camel-yaml-dsl-validator` ← dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/main/java/org/apache/camel/dsl/yaml/validator/SchemaHints.java, dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/test/java/org/apache/camel/dsl/yaml/validator/YamlValidatorPropertyHintTest.java
- `camel-yaml-dsl-validator-maven-plugin` ← downstream of org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (9)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (17 modules, 3m 42s total)</summary>
**Total reactor time:** 3m 42s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: JBang :: Plugin :: TUI | 54.0s | SUCCESS |
| Camel :: Launcher | 53.2s | SUCCESS |
| Camel :: JBang :: MCP | 42.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 23.0s | SUCCESS |
| Camel :: YAML DSL :: Validator | 12.1s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 10.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 8.8s | SUCCESS |
| Camel :: Coverage | 5.5s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 3.4s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.5s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 1.5s | SUCCESS |
| Camel :: JBang :: Integration tests | 1.3s | SUCCESS |
| Camel :: JBang :: Main | 0.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 0.9s | SUCCESS |
| Camel :: Launcher :: Container | 0.7s | SUCCESS |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: JBang :: Plugin :: TUI` (54.0s)
- `Camel :: Launcher` (53.2s)
- `Camel :: JBang :: MCP` (42.6s)
- `Camel :: JBang :: Plugin :: Kubernetes` (23.0s)
- `Camel :: YAML DSL :: Validator` (12.1s)
- `Camel :: JBang :: Plugin :: Testing` (10.8s)
- `Camel :: JBang :: Plugin :: Validate` (8.8s)
- `Camel :: Coverage` (5.5s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (3.4s)
- `Camel :: JBang :: Plugin :: Generate` (1.8s)
- `Camel :: JBang :: Plugin :: Edit` (1.5s)
- `Camel :: JBang :: Plugin :: MCP` (1.5s)
- `Camel :: JBang :: Integration tests` (1.3s)
- `Camel :: JBang :: Main` (0.9s)
- `Camel :: JBang :: Plugin :: Route Parser` (0.9s)
- `Camel :: Launcher :: Container` (0.7s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/35522559240)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org