You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Alexander Kolbasov (JIRA)" <ji...@apache.org> on 2018/05/01 17:47:00 UTC

[jira] [Commented] (HIVE-19337) Partition whitelist regex doesn't work (and never did)

    [ https://issues.apache.org/jira/browse/HIVE-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459917#comment-16459917 ] 

Alexander Kolbasov commented on HIVE-19337:
-------------------------------------------

Attaching the same patch - for some reason it failed to apply the first time.

> Partition whitelist regex doesn't work (and never did)
> ------------------------------------------------------
>
>                 Key: HIVE-19337
>                 URL: https://issues.apache.org/jira/browse/HIVE-19337
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 2.3.3
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Major
>         Attachments: HIVE-19337.01.branch-2.patch, HIVE-19337.02.branch-2.patch
>
>
> {{ObjectStore.setConf()}} has the following code:
> {code:java}
> String partitionValidationRegex =
>  hiveConf.get(HiveConf.ConfVars.METASTORE_PARTITION_NAME_WHITELIST_PATTERN.name());
> {code}
>  Note that it uses name() method which returns enum name (METASTORE_PARTITION_NAME_WHITELIST_PATTERN) rather then .varname
> As a result the regex will always be null.
> The code was introduced as part of 
> HIVE-7223 Support generic PartitionSpecs in Metastore partition-functions
> So looks like this was broken since the original code drop. This is fixed in Hive3 - probably when [~alangates] reworked access to configuration (HIVE-17733) so it isn't a bug in Hive-3.
> [~stakiar_impala_496e] FYI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)