You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/25 09:18:27 UTC
[GitHub] [couchdb-mango] hklarner opened a new pull request #48: adds operators $sizeLte and $sizeGte
hklarner opened a new pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48
- supports inequality matches for `$size`
- example: between 10 and 20 customers in array
- `"doc.customers": {"$sizeGte": 10}`
- `"doc.customers": {"$sizeLte": 20}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] hklarner commented on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
hklarner commented on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847821737
Here is the PR for the current repo
- https://github.com/apache/couchdb/pull/3582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] hklarner commented on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
hklarner commented on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847813134
> So I want to know if you came up with the operators or got the operators from somewhere else?
Yes, came up with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] hklarner edited a comment on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
hklarner edited a comment on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847802167
> We no longer use this repo. Mango is fully integrated into the main couchdb repo
Ok.
> Could you add some tests to check this works as expected and handles the error cases
Ok.
> Where did you get the $sizeLte and $sizeGte operators.
Oh. I thought the operators were defined in `src/mango_selector.erl` :sweat_smile:
> I think you might have to send an email to the Couchdb dev mailing saying you want to add these operators and check everyone is happy with that.
What's the couchdb dev email address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] hklarner commented on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
hklarner commented on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847802167
> Mongodb
Ok.
> Could you add some tests to check this works as expected and handles the error cases
Ok.
> Where did you get the $sizeLte and $sizeGte operators.
Oh. I thought the operators were defined in `src/mango_selector.erl` :sweat_smile:
> I think you might have to send an email to the Couchdb dev mailing saying you want to add these operators and check everyone is happy with that.
What's the couchdb dev email address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] garrensmith commented on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
garrensmith commented on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847810675
Mailing lists can be found on the website. scroll down to the mailing list section https://couchdb.apache.org/
> Oh. I thought the operators were defined in src/mango_selector.erl 😅
What I mean is that most the operators are based off the MongoDB operators. I couldn't find these operators defined for MongoDB. So I want to know if you came up with the operators or got the operators from somewhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] hklarner edited a comment on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
hklarner edited a comment on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847802167
> Mongodb
Ok.
> Could you add some tests to check this works as expected and handles the error cases
Ok.
> Where did you get the $sizeLte and $sizeGte operators.
Oh. I thought the operators were defined in `src/mango_selector.erl` :sweat_smile:
> I think you might have to send an email to the Couchdb dev mailing saying you want to add these operators and check everyone is happy with that.
What's the couchdb dev email address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-mango] garrensmith commented on pull request #48: adds operators $sizeLte and $sizeGte
Posted by GitBox <gi...@apache.org>.
garrensmith commented on pull request #48:
URL: https://github.com/apache/couchdb-mango/pull/48#issuecomment-847790726
Hi @hklarner this is an interesting idea and thank you for adding the code. A few things will have to be done before this could land:
* We no longer use this repo. Mango is fully integrated into the main couchdb repo https://github.com/apache/couchdb/tree/main/src/mango so you will have to apply this patch to the couchdb repo
* Could you add some tests to check this works as expected and handles the error cases
* Where did you get the `$sizeLte` and `$sizeGte` operators. I couldn't find them in Mongodb. So the idea sounds good but I think you might have to send an email to the Couchdb dev mailing saying you want to add these operators and check everyone is happy with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org