You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/01 09:42:59 UTC
[GitHub] yanlin-Lynn commented on a change in pull request #23369:
[SPARK-26429][SS]add jdbc sink for Structured Streaming.
yanlin-Lynn commented on a change in pull request #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.
URL: https://github.com/apache/spark/pull/23369#discussion_r244632164
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcSourceProvider.scala
##########
@@ -17,12 +17,20 @@
package org.apache.spark.sql.execution.datasources.jdbc
+import scala.collection.JavaConverters._
+
import org.apache.spark.sql.{AnalysisException, DataFrame, SaveMode, SQLContext}
import org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils._
import org.apache.spark.sql.sources.{BaseRelation, CreatableRelationProvider, DataSourceRegister, RelationProvider}
+import org.apache.spark.sql.sources.v2.{DataSourceOptions, StreamingWriteSupportProvider}
+import org.apache.spark.sql.sources.v2.writer.streaming.StreamingWriteSupport
+import org.apache.spark.sql.streaming.OutputMode
+import org.apache.spark.sql.types.StructType
-class JdbcRelationProvider extends CreatableRelationProvider
- with RelationProvider with DataSourceRegister {
+class JdbcSourceProvider extends CreatableRelationProvider
Review comment:
I think it's OK, because the `shortName` method is the same, so users using`format("jdbc")` are not affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org