You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by PaulAngus <gi...@git.apache.org> on 2016/05/10 20:31:59 UTC
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
GitHub user PaulAngus opened a pull request:
https://github.com/apache/cloudstack/pull/1537
Remove extraneous log directory and add catalina.out log rotation
rebased and squashed
replacement for PR: https://github.com/apache/cloudstack/pull/1087
Remove extraneous log directory (/var/log/cloudstack-management)
and adds catalina.out log rotation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulAngus/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1537
----
commit a90dff507b155ba9977a4aa1e986eeea4f80d717
Author: Paul Angus <pa...@shapeblue.com>
Date: 2016-05-10T20:24:29Z
Remove extraneous log directory and add catalina.out log rotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
GitHub user PaulAngus reopened a pull request:
https://github.com/apache/cloudstack/pull/1537
Remove extraneous log directory and add catalina.out log rotation
rebased and squashed
replacement for PR: https://github.com/apache/cloudstack/pull/1087
Remove extraneous log directory (/var/log/cloudstack-management)
and adds catalina.out log rotation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulAngus/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1537
----
commit 11e3582fdf2ab94e70591f4603e84db59519f342
Author: Paul Angus <pa...@shapeblue.com>
Date: 2016-05-10T20:24:29Z
Remove extraneous log directory and add catalina.out log rotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218790646
@PaulAngus I just pushed a fix for the Travis problems you experienced. Can you please re-push this PR so we can try to get it all green so we can get it merged. Thanks again for the support...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-219079650
Thank you for your patience sir. \U0001f44d I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-219077622
Hurrah!!
passed both this time @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218374853
@PaulAngus can you squash the changes, so on the PR we get the changes as one single commit.
You can do:
```
git checkout master # your master
git remote add upstream https://git-wip-us.apache.org/repos/asf/cloudstack.git # do this if upstream is not already added
git pull --rebase upstream master
# squash your changes: [1]
git rebase -i HEAD~5
# convert pick to s or squash all commits except for your first commit
# rebase again:
git pull --rebase upstream master
# push -f on your repo/branch
git push origin master -fv
```
[1] http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
GitHub user PaulAngus reopened a pull request:
https://github.com/apache/cloudstack/pull/1537
Remove extraneous log directory and add catalina.out log rotation
rebased and squashed
replacement for PR: https://github.com/apache/cloudstack/pull/1087
Remove extraneous log directory (/var/log/cloudstack-management)
and adds catalina.out log rotation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulAngus/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1537
----
commit 11e3582fdf2ab94e70591f4603e84db59519f342
Author: Paul Angus <pa...@shapeblue.com>
Date: 2016-05-10T20:24:29Z
Remove extraneous log directory and add catalina.out log rotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218648555
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 6h 07m 12s
```
**Summary of the problem(s):**
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be successful!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_RIXF85/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL/runinfo.txt)
**`/tmp/MarvinLogs/test_network_RIXF85:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_network_RIXF85/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_network_RIXF85/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_network_RIXF85/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_SQ90BE:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_vpc_routers_SQ90BE/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_vpc_routers_SQ90BE/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_vpc_routers_SQ90BE/runinfo.txt)
Uploads will be available until `2016-07-12 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
GitHub user PaulAngus reopened a pull request:
https://github.com/apache/cloudstack/pull/1537
Remove extraneous log directory and add catalina.out log rotation
rebased and squashed
replacement for PR: https://github.com/apache/cloudstack/pull/1087
Remove extraneous log directory (/var/log/cloudstack-management)
and adds catalina.out log rotation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulAngus/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1537
----
commit 11e3582fdf2ab94e70591f4603e84db59519f342
Author: Paul Angus <pa...@shapeblue.com>
Date: 2016-05-10T20:24:29Z
Remove extraneous log directory and add catalina.out log rotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218744867
Jenkins has run successfully @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-219119839
Thanks Will.
Kind regards,
Paul Angus
Regards
Paul Angus
VP Technology
www.shapeblue.com
From: Will Stevens [mailto:notifications@github.com]
Sent: 13 May 2016 16:38
To: apache/cloudstack <cl...@noreply.github.com>
Cc: Paul Angus <pa...@shapeblue.com>; State change <st...@noreply.github.com>
Subject: Re: [apache/cloudstack] Remove extraneous log directory and add catalina.out log rotation (#1537)
Thank you for your patience sir. \U0001f44d I will get this merged...
\u2014
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/1537#issuecomment-219079650>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218503981
I am testing now... \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218470411
LGTM, @swill, I am being very formal but can you queue this for integration tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218648825
This one is ready other than Jenkins. @PaulAngus, can you please either force push the PR or close and reopen it so it kicks off Jenkins so we can get this PR all green. It is ready to merge otherwise...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218398335
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---